-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virt: adding kernel boot parameters to libvirt xml #55245 #197
Merged
meaksh
merged 2 commits into
openSUSE:openSUSE-2019.2.0
from
larrydewey:openSUSE-2019.2.0
Jan 7, 2020
Merged
virt: adding kernel boot parameters to libvirt xml #55245 #197
meaksh
merged 2 commits into
openSUSE:openSUSE-2019.2.0
from
larrydewey:openSUSE-2019.2.0
Jan 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com>
Signed-off-by: Larry Dewey <ldewey@suse.com>
Has been merged upstream. |
meaksh
approved these changes
Jan 7, 2020
meaksh
pushed a commit
that referenced
this pull request
Jan 7, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
brejoc
pushed a commit
that referenced
this pull request
Jan 31, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
that referenced
this pull request
Mar 10, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
brejoc
pushed a commit
that referenced
this pull request
Mar 20, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
that referenced
this pull request
Mar 23, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
that referenced
this pull request
Mar 24, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
brejoc
pushed a commit
that referenced
this pull request
Apr 8, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
that referenced
this pull request
Apr 30, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
that referenced
this pull request
May 20, 2020
* virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the kernel path, initrd path, and kernel boot command line parameters to libvirt xml for use with SUSE's autoyast and Red Hat's kickstart.
What issues does this PR fix or reference?
N/A
New Behavior
Adds an additional parameter 'boot=None' to a number of functions, allowing the kernel path, the initrd path, and the kernel boot command line string to be parse and added to the xml.
Tests written?
Yes
Commits signed with GPG?
Yes
Backport of PR saltstack/salt#55245