Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt: adding kernel boot parameters to libvirt xml #55245

Merged
merged 2 commits into from
Jan 1, 2020
Merged

virt: adding kernel boot parameters to libvirt xml #55245

merged 2 commits into from
Jan 1, 2020

Conversation

larrydewey
Copy link
Contributor

What does this PR do?

This PR adds the kernel path, initrd path, and kernel boot command line parameters to libvirt xml for use with SUSE's autoyast and Red Hat's kickstart.

What issues does this PR fix or reference?

N/A

New Behavior

Adds an additional parameter 'boot=None' to a number of functions, allowing the kernel path, the initrd path, and the kernel boot command line string to be parse and added to the xml.

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.

Yes

Commits signed with GPG?

Yes

@larrydewey larrydewey requested a review from a team as a code owner November 8, 2019 19:50
@ghost ghost requested a review from garethgreenaway November 8, 2019 19:51
cbosdo
cbosdo suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, but I would add remote kernel/initrd download.

salt/modules/virt.py Show resolved Hide resolved
@bryceml
Copy link
Contributor

bryceml commented Nov 21, 2019

re-run full all

@larrydewey larrydewey changed the title virt: adding kernel boot parameters to libvirt xml WIP: virt: adding kernel boot parameters to libvirt xml Nov 27, 2019
cbosdo
cbosdo suggested changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

salt/modules/virt.py Outdated Show resolved Hide resolved
salt/utils/virt.py Show resolved Hide resolved
tests/unit/modules/test_virt.py Show resolved Hide resolved
@larrydewey
Copy link
Contributor Author

larrydewey commented Dec 20, 2019 •
edited
Loading

Not entirely sure if the ci/lint issue is something I caused. @cbosdo have you run into this before?
Fixed...

@larrydewey larrydewey changed the title WIP: virt: adding kernel boot parameters to libvirt xml virt: adding kernel boot parameters to libvirt xml Dec 23, 2019
cbosdo
cbosdo approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7ed2696). Click here to learn what that means.
The diff coverage is 12.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55245   +/-   ##
=========================================
  Coverage          ?   18.79%           
=========================================
  Files             ?      822           
  Lines             ?   175254           
  Branches          ?    37710           
=========================================
  Hits              ?    32930           
  Misses            ?   139680           
  Partials          ?     2644
Flag Coverage Δ
#archlts 18.07% <12.07%> (?)
#centos7 23.74% <ø> (?)
#proxy 23.77% <ø> (?)
#py2 18.59% <12.07%> (?)
#py3 18.42% <12.07%> (?)
#runtests 18.79% <12.07%> (?)
#ubuntu1604 23.71% <ø> (?)
#zeromq 18.79% <12.07%> (?)
Impacted Files Coverage Δ
salt/utils/virt.py 26.99% <26.32%> (ø)
salt/modules/virt.py 9.75% <5.13%> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7ed2696). Click here to learn what that means.
The diff coverage is 12.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55245   +/-   ##
=========================================
  Coverage          ?   18.79%           
=========================================
  Files             ?      822           
  Lines             ?   175254           
  Branches          ?    37710           
=========================================
  Hits              ?    32930           
  Misses            ?   139680           
  Partials          ?     2644
Flag Coverage Δ
#archlts 18.07% <12.07%> (?)
#centos7 23.74% <ø> (?)
#proxy 23.77% <ø> (?)
#py2 18.59% <12.07%> (?)
#py3 18.42% <12.07%> (?)
#runtests 18.79% <12.07%> (?)
#ubuntu1604 23.71% <ø> (?)
#zeromq 18.79% <12.07%> (?)
Impacted Files Coverage Δ
salt/utils/virt.py 26.99% <26.32%> (ø)
salt/modules/virt.py 9.75% <5.13%> (ø)

@larrydewey
virt: adding kernel boot parameters to libvirt xml
a0059dc 
SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>
@larrydewey
virt: Download linux and initrd
bae600b 
Signed-off-by: Larry Dewey <ldewey@suse.com>
@larrydewey
Copy link
Contributor Author

larrydewey commented Dec 30, 2019 •
edited
Loading

The tests which failed were a result of issues with the test (one with a Java memory issue, the other with being unable to reach a required resource) and not with the code. Should be ready to merge in.

@waynew
Copy link
Contributor

waynew commented Dec 30, 2019

I've re-started the two failing builds, let's see how they run.

@dwoz dwoz merged commit 3730c20 into saltstack:master Jan 1, 2020
@larrydewey larrydewey mentioned this pull request Jan 6, 2020
Merged
admd pushed a commit to admd/salt-1 that referenced this pull request Jan 27, 2020
@larrydewey @meaksh
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
26a2278 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh pushed a commit to meaksh/salt that referenced this pull request Mar 10, 2020
@larrydewey @brejoc
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
f8ccfae 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul pushed a commit to agraul/salt that referenced this pull request Apr 22, 2020
@larrydewey @brejoc
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
5aa076b 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh pushed a commit to meaksh/salt that referenced this pull request Apr 22, 2020
@larrydewey @meaksh
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
ce8d431 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul pushed a commit to agraul/salt that referenced this pull request Apr 27, 2020
@larrydewey @meaksh
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
8d7a599 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh pushed a commit to meaksh/salt that referenced this pull request Apr 13, 2021
@larrydewey @meaksh
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
24f5c30 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul pushed a commit to agraul/salt that referenced this pull request Jun 25, 2021
@larrydewey @meaksh
virt: adding kernel boot parameters to libvirt xml saltstack#55245 (s…
8bff21c 
…altstack#197)

* virt: adding kernel boot parameters to libvirt xml

SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths,
initrd paths, and kernel boot command line parameters. These changes
provide the option of using these, and will allow salt and
autoyast/kickstart to work together.

Signed-off-by: Larry Dewey <ldewey@suse.com>

* virt: Download linux and initrd

Signed-off-by: Larry Dewey <ldewey@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbosdo cbosdo cbosdo approved these changes

@dwoz dwoz dwoz approved these changes

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@larrydewey @bryceml @waynew @cbosdo @dwoz