[SAI-PTF]Include sai expermential for generate the rpc headers #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu <richardyu@contoso.com>
richardyu-ms
added a commit
to richardyu-ms/SAI
that referenced
this pull request
Nov 20, 2022
…omputeproject#1660) When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu <richardyu@contoso.com> Signed-off-by: richardyu <richardyu@contoso.com> Co-authored-by: richardyu <richardyu@contoso.com>
richardyu-ms
added a commit
to richardyu-ms/SAI
that referenced
this pull request
Nov 20, 2022
…omputeproject#1660) When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
added a commit
that referenced
this pull request
Nov 20, 2022
#1661) When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
added a commit
to richardyu-ms/sonic-sairedis
that referenced
this pull request
Nov 23, 2022
cherry-pick from sonic-net#1155 Advance SAI head pointer [SAI-PTF]add conditional import for unit test opencomputeproject/SAI#1656 [SAI-PTF] add invocation logger opencomputeproject/SAI#1651 [SAI-PTF]Include sai expermential for generate the rpc headers opencomputeproject/SAI#1660 Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
added a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Nov 23, 2022
cherry-pick from #1155 Advance SAI head pointer [SAI-PTF]add conditional import for unit test opencomputeproject/SAI#1656 [SAI-PTF] add invocation logger opencomputeproject/SAI#1651 [SAI-PTF]Include sai expermential for generate the rpc headers opencomputeproject/SAI#1660 Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
Dec 14, 2022
…omputeproject#1660) When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu <richardyu@contoso.com> Signed-off-by: richardyu <richardyu@contoso.com> Co-authored-by: richardyu <richardyu@contoso.com>
|
@richardyu-ms what errors this causing ? since i test this locally and with experimental include or not i still get the same gen-py/sai/sai_headers.py generated can you share exact steps how you reproduce that the experimental are missing? |
@kcudnik I cannot recall the actual vendor OS version which caused this issue, but i remember the RC was the local SAI headers(from SAI repo) did not match the vendor SAI headers within their SDK |
|
yes, differences between vendor and actual SAI headers can lead to weird errors, and it could be even hard to track, since they can pop up while runtime at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72
In gensairpc
https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132
But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences.
Test done:
Local compile and checked the headers