[cherry-pick][SAI-PTF]Include sai expermential for generate the rpc headers (#1660) #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omputeproject#1660) When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72 ``` CFLAGS += -I../inc -I../experimental $(WARNINGS) ``` In gensairpc https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132 ``` our $EXPERIMENTAL_DIR = catdir( $sai_dir, 'experimental' ); ``` But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences. Test done: Local compile and checked the headers Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
richardyu-ms
force-pushed
the
fix-sai-experimental_1.11
branch
from
46194b5 to
7222e8a
Compare
richardyu-ms
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generate the sai_adapter it depends on the files in sai expermental https://github.com/opencomputeproject/SAI/blob/master/meta/Makefile#L72
In gensairpc
https://github.com/opencomputeproject/SAI/blob/master/meta/gensairpc.pl#L132
But when generate the py headers for RPC service, it doesn't include that. In order to make them matched, then add that dependences.
Test done:
Local compile and checked the headers
Signed-off-by: richardyu richardyu@contoso.com
Signed-off-by: richardyu richardyu@contoso.com
Co-authored-by: richardyu richardyu@contoso.com