schema/defs-image: Remove 'null' from valid annotations #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'null' option has been in the JSON Schema since 78c7ff7 (manifest: add annotations, 2016-04-27, opencontainers#44), although I expect it was accidental. The spec has clearly not allowed: "annotations": null since 873b9b6 (Add some text about extensions, 2016-06-26, opencontainers#164) landed with the following (still current) requirements: Annotations MUST be a key-value map where both the key and value MUST be strings. and: If there are no annotations then this property MUST either be absent or be an empty map. Folks without annotations should not set the property at all, or they should set it to: "annotations": {} Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
annotations-does-not-permit-null
branch
from
d3332d5
to
acd8a30
Compare
|
LGTM |
|
@opencontainers/image-spec-maintainers PTAL |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nulloption has been in the JSON Schema since #44, although I expect it was accidental. The spec has clearly not allowed:since #164 landed with the following (still current) requirements:
and:
Folks without annotations should not set the property at all, or they should set it to: