Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/defs-image: Remove 'null' from valid annotations #539

Merged

Commits on Jan 28, 2017

  1. schema/defs-image: Remove 'null' from valid annotations

    The 'null' option has been in the JSON Schema since 78c7ff7
    (manifest: add annotations, 2016-04-27, opencontainers#44), although I expect it was
    accidental.  The spec has clearly not allowed:
    
      "annotations": null
    
    since 873b9b6 (Add some text about extensions, 2016-06-26, opencontainers#164)
    landed with the following (still current) requirements:
    
      Annotations MUST be a key-value map where both the key and value
      MUST be strings.
    
    and:
    
      If there are no annotations then this property MUST either be absent
      or be an empty map.
    
    Folks without annotations should not set the property at all, or they
    should set it to:
    
      "annotations": {}
    
    Signed-off-by: W. Trevor King <wking@tremily.us>
    wking committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    acd8a30 View commit details
    Browse the repository at this point in the history