Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kmem.tcp limit #376

Closed
wants to merge 1 commit into from
Closed

Add support for kmem.tcp limit #376

wants to merge 1 commit into from

Conversation

yangdongsheng
Copy link

Signed-off-by: Dongsheng Yang yangds.fnst@cn.fujitsu.com

Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
@yangdongsheng
Copy link
Author

janky failed because we need to wait opencontainers/runtime-spec#235 merged and godeps/specs in runc updated.

@mrunalp
Copy link
Contributor

mrunalp commented Oct 29, 2015

Yes, we will wait for this to be merged upstream.

@mrunalp
Copy link
Contributor

mrunalp commented Jan 26, 2016

Needs to be updated.

@yangdongsheng
Copy link
Author

@mrunalp sorry for the late. But I have something have to deal with recently. Maybe it's next week when I can update this branch.

@crosbymichael crosbymichael modified the milestone: 0.0.9 Feb 10, 2016
@cyphar
Copy link
Member

cyphar commented Feb 15, 2016

@yangdongsheng Does kmem.tcp.limit_in_bytes have the same issue as kmem.limit_in_bytes (you can only change the limit when there's no processes in the cgroup)? If so, this should be put inside SetKernelMemory when you do your rebase.

If you're still busy, I can carry this.

@cyphar
Copy link
Member

cyphar commented Mar 20, 2016

I've carried this PR in #665.

@hqhq hqhq closed this Mar 21, 2016
@yangdongsheng
Copy link
Author

Oh, @cyphar . Thanx a lot.

stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
Add project.md to table of contents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants