cgroup: Add support for memory.kmem.tcp.limit_in_bytes #235
Conversation
Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
|
while i'm not opposed to this particularly, It does circle back to the conversation about requiring a field for every kernel parameter that exists. |
|
Yes. Frankly I don't see much value in this unless we provide a higher level abstraction like that of lmctfy. |
|
There is an on-going discussion about cgroups support in the mailing list. Lets hold on to this PR until that thread comes to a conclusion. |
|
@vishh That's fine. I will read the discussion then. Thanx for your review. :) |
|
@vishh thoughts on revisiting this? or proposal on better abstraction? |
|
@vbatts: Cgroup parameters have to be pointers. That is the current agreement. This PR requires that change, otherwise LGTM! |
|
@hqhq Thanx, that's good point. I agree with that. |
|
SGTM. |
cgroup: Add support for memory.kmem.tcp.limit_in_bytes
| @@ -201,6 +201,8 @@ The following parameters can be specified to setup the controller: | |||
|
|
|||
| * **`kernel`** *(uint64, optional)* - sets hard limit for kernel memory | |||
|
|
|||
| * **`kernelTCP`** *(uint64, optional)* - sets hard limit for kernel memory in tcp using | |||
There was a problem hiding this comment.
using… what? We still have this unfinished sentence in the current tip.
There was a problem hiding this comment.
Oops.. @wking Can you post a PR to fix this ?
There was a problem hiding this comment.
There was a problem hiding this comment.
i didn't address this comment
On Mon, Apr 11, 2016 at 6:59 PM, W. Trevor King notifications@github.com
wrote:
In runtime-config-linux.md
#235 (comment)
:@@ -201,6 +201,8 @@ The following parameters can be specified to setup the controller:
kernel(uint64, optional) - sets hard limit for kernel memory+*
kernelTCP(uint64, optional) - sets hard limit for kernel memory in tcp usingOn Mon, Apr 11, 2016 at 03:54:09PM -0700, Vish Kannan wrote: > +*
kernelTCP(uint64, optional) - sets hard limit for kernel memory in
tcp using Oops.. @wking https://github.com/wking Can you post a PR to
fix this ?
@vbatts https://github.com/vbatts just pushed c1612af
c1612af
→ d4e7326
d4e7326
in #370 #370 which
should cover this.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/opencontainers/runtime-spec/pull/235/files/e9a6d94848a3be8a65bc68c3b2c52639041504ed#r59296300
Avoid the dangling 'using' from e9a6d94 (cgroup: Add support for memory.kmem.tcp.limit_in_bytes, 2015-10-26, opencontainers#235). This looks like it's aimed at memory.kmem.tcp.limit_in_bytes [1], so I've tried to echo the kernel docs by mentioning buffer memory. I'd personally prefer linking to the kernel docs and mentioning memory.kmem.tcp.limit_in_bytes, but that seemed like too big of a break from the existing style for this commit. [1]: https://kernel.org/doc/Documentation/cgroup-v1/memory.txt Signed-off-by: W. Trevor King <wking@tremily.us>
Avoid the dangling 'using' from e9a6d94 (cgroup: Add support for memory.kmem.tcp.limit_in_bytes, 2015-10-26, opencontainers#235). I've tried to echo the kernel docs by mentioning buffer memory [1]. I'd personally prefer linking to the kernel docs and mentioning memory.kmem.tcp.limit_in_bytes, but that seemed like too big of a break from the existing style for this commit. [1]: https://kernel.org/doc/Documentation/cgroup-v1/memory.txt Signed-off-by: W. Trevor King <wking@tremily.us>
Avoid the dangling 'using' from e9a6d94 (cgroup: Add support for memory.kmem.tcp.limit_in_bytes, 2015-10-26, opencontainers#235). I've tried to echo the kernel docs by mentioning buffer memory [1]. I'd personally prefer linking to the kernel docs and mentioning memory.kmem.tcp.limit_in_bytes, but that seemed like too big of a break from the existing style for this commit. [1]: https://kernel.org/doc/Documentation/cgroup-v1/memory.txt Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: Dongsheng Yang yangds.fnst@cn.fujitsu.com