Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v0.4.0 #336

Merged
merged 4 commits into from
Mar 10, 2016
Merged

Bump v0.4.0 #336

merged 4 commits into from
Mar 10, 2016

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Mar 9, 2016

No description provided.

@vbatts vbatts added this to the v0.4.0 milestone Mar 9, 2016
@vishh
Copy link
Contributor

vishh commented Mar 9, 2016

LGTM

@wking
Copy link
Contributor

wking commented Mar 9, 2016

On Wed, Mar 09, 2016 at 11:09:15AM -0800, Vincent Batts wrote:

  • version: v0.4.0
  • version: bump v0.5.0-dev

Changelog? Should I work one up and post a Gist like I did for
v0.3.0?

@vbatts
Copy link
Member Author

vbatts commented Mar 9, 2016

@wking yes please!

On Wed, Mar 9, 2016 at 2:38 PM, W. Trevor King notifications@github.com
wrote:

On Wed, Mar 09, 2016 at 11:09:15AM -0800, Vincent Batts wrote:

  • version: v0.4.0
  • version: bump v0.5.0-dev

Changelog? Should I work one up and post a Gist like I did for
v0.3.0?

—
Reply to this email directly or view it on GitHub
#336 (comment).

@wking
Copy link
Contributor

wking commented Mar 9, 2016 via email

@vbatts
Copy link
Member Author

vbatts commented Mar 9, 2016

i'll rebase once the milestone is clear.

On Wed, Mar 9, 2016 at 2:46 PM, W. Trevor King notifications@github.com
wrote:

Did you want to rebase around #331 (landed in master since this branch
broke away)? Are we freezing master until this lands?

—
Reply to this email directly or view it on GitHub
#336 (comment).

@vbatts
Copy link
Member Author

vbatts commented Mar 9, 2016

rebased with @wking changelog

@crosbymichael
Copy link
Member

last commit lacks DCO

@wking
Copy link
Contributor

wking commented Mar 10, 2016

On Wed, Mar 09, 2016 at 04:51:30PM -0800, Michael Crosby wrote:

last commit lacks DCO

Oops. I just pushed 8901446 to 1, along with ChangeLog updates
covering changes after 3b7c15d (@VBatt's initial branching-off point)
through eea2a6c (his current branching-off point).

wking and others added 4 commits March 10, 2016 18:49
@wking @vbatts
ChangeLog: Strip trailing whitespace
2042424 
Signed-off-by: W. Trevor King <wking@tremily.us>
@wking @vbatts
ChangeLog: Document changes since v0.3.0
698d930 
Through 0bcb711 (Merge pull request opencontainers#341 2016-03-10).

Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
version: v0.4.0
3ce138b 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
version: bump v0.5.0-dev
ab44e37 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
Copy link
Member Author

vbatts commented Mar 10, 2016

just rebased again, and added a couple more items

@wking
Copy link
Contributor

wking commented Mar 10, 2016

On Thu, Mar 10, 2016 at 10:56:03AM -0800, Vincent Batts wrote:

just rebased again, and added a couple more items

I'd mention #335 and #337 as well, but ab44e37 looks fine to me.

@vbatts
Copy link
Member Author

vbatts commented Mar 10, 2016

Those seem minor enough.

PTAL

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Mar 10, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Mar 10, 2016
Merge pull request #336 from vbatts/bump-v0.4.0
4103108 
Bump v0.4.0
@mrunalp mrunalp merged commit 4103108 into opencontainers:master Mar 10, 2016
@vbatts vbatts deleted the bump-v0.4.0 branch March 10, 2016 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vbatts @vishh @wking @crosbymichael @mrunalp