validate: increase os verification to checklinux #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
|
OS limitation we have checked in CheckOS() before, here is not necessary. |
If the error in the |
|
Plaform has been removed from spec, so closing this. |
|
@Mashimiao I think only need rebase on it. This judgment is still needed, as I said above, through this judgment can reduce the number of unnecessary functions to run. |
|
reopened, but I think this fix is not suitable. It will be better if we can add judge if target platform is linux to work with v.spec.Linux != nil |
|
On Thu, Jul 06, 2017 at 07:35:42AM +0000, Ma Shimiao wrote:
It will be better if we can add judge if target platform is linux to
work with v.spec.Linux != nil
We could rebase this PR to use Validator.platform [1].
But with rc6 there's wrong with setting the ‘linux’ property in a
config targeting the ‘linux’ platform [2]. I expect we want to
continue calling CheckLinux whenever the ‘linux’ property is set
(which we currently do [3]). We probably want to skip the
host-specific checks if the target platform is not Linux, but we can
check the host-independent parts of the ‘linux’ property even if the
target platform is ‘windows’ (for example). So I'm in favor of
re-closing this PR.
[1]: https://github.com/opencontainers/runtime-tools/blob/0d35fc8437ec8292cd7065e332000c584f7024c5/validate/validate.go#L51
[2]: https://github.com/opencontainers/runtime-spec/blame/v1.0.0-rc6/config.md#L346-L347
[3]: https://github.com/opencontainers/runtime-tools/blob/0d35fc8437ec8292cd7065e332000c584f7024c5/validate/validate.go#L105-L106
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
osis notlinux, then do not have to implement the next code, improve efficiency.Signed-off-by: zhouhao zhouhao@cn.fujitsu.com