Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform config could exist even platform is different #416

Merged
merged 1 commit into from
Jul 12, 2017
Merged

platform config could exist even platform is different #416

merged 1 commit into from
Jul 12, 2017

Conversation

liangchenye
Copy link
Member

Signed-off-by: liangchenye liangchenye@huawei.com

@liangchenye
platform config could exist even platform is different
798324d 
Signed-off-by: liangchenye <liangchenye@huawei.com>
@liangchenye
Copy link
Member Author

The spec is changed from

linux (object, optional) Linux-specific configuration. This SHOULD only be set if platform.os is linux.
solaris (object, optional) Solaris-specific configuration. This SHOULD only be set if platform.os is solaris.

to

linux (object, OPTIONAL) Linux-specific configuration. This MAY be set if the target platform of this spec is linux.
windows (object, OPTIONAL) Windows-specific configuration. This MUST be set if the target platform of this spec is windows.
solaris (object, OPTIONAL) Solaris-specific configuration. This MAY be set if the target platform of this spec is solaris.

So I added this PR. @q384566678 @Mashimiao
I notice this when I worked on #66 .

@Mashimiao
Copy link

Mashimiao commented Jul 6, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@wking wking mentioned this pull request Jul 10, 2017
Merged
@zhouhao3 zhouhao3 mentioned this pull request Jul 11, 2017
Closed
@Mashimiao
Copy link

ping @hqhq @mrunalp

@mrunalp
Copy link
Contributor

mrunalp commented Jul 11, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@Mashimiao
Copy link

Mashimiao commented Jul 12, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@Mashimiao Mashimiao merged commit e3c6364 into opencontainers:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@wking wking wking approved these changes

@zhouhao3 zhouhao3 zhouhao3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liangchenye @Mashimiao @mrunalp @wking @zhouhao3