Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add test notebooks to catch the ubi9 images and fix the version name #802

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented May 3, 2023

This PR adds test Notebook objects to catch the ubi9 images on tests/resources/notebook-controller/notebooks/ folder as well as it fixes the tag version name on spec.container.image field on the cuda notebooks which is connected with the: #822

Fixes: opendatahub-io/notebooks#100

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@atheo89 atheo89 changed the title Add test notebooks to catch the ubi9 images Add test notebooks to catch the ubi9 images and fix the tags May 17, 2023
@atheo89 atheo89 changed the title Add test notebooks to catch the ubi9 images and fix the tags Add test notebooks to catch the ubi9 images and fix the version name May 17, 2023
@atheo89 atheo89 marked this pull request as ready for review May 22, 2023 09:38
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks for fixing the naming as well.

@harshad16
Copy link
Member

/hold

Till PR :#822 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Hold off on merging (provide reason in comment) label May 23, 2023
@openshift-ci openshift-ci bot removed the lgtm label Jun 1, 2023
@atheo89 atheo89 force-pushed the add-test-nbk-ubi9 branch 2 times, most recently from f0cce7a to d361930 Compare June 6, 2023 15:27
@atheo89
Copy link
Member Author

atheo89 commented Jun 14, 2023

/hold

Till PR :#822 is merged.

We should do the opposite! Update the repo with the new tests and then merge the other

@atheo89
Copy link
Member Author

atheo89 commented Jun 14, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Hold off on merging (provide reason in comment) label Jun 14, 2023
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
Once this PR has been reviewed and has the lgtm label, please assign anishasthana for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 83ad786 into opendatahub-io:master Jun 14, 2023
atheo89 added a commit to atheo89/odh-manifests that referenced this pull request Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include tests case in odh-manifests for ubi9 based images
2 participants