-
Notifications
You must be signed in to change notification settings - Fork 211
Add test notebooks to catch the ubi9 images and fix the version name #802
Conversation
Skipping CI for Draft Pull Request. |
fd007a5
to
c31241e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks for fixing the naming as well.
/hold Till PR :#822 is merged. |
c31241e
to
8322190
Compare
f0cce7a
to
d361930
Compare
d361930
to
de83aff
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks 💯
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pendatahub-io#802) Add test notebooks to catch the ubi9 images
This PR adds test Notebook objects to catch the ubi9 images on
tests/resources/notebook-controller/notebooks/
folder as well as it fixes the tag version name onspec.container.image
field on the cuda notebooks which is connected with the: #822Fixes: opendatahub-io/notebooks#100
Merge criteria: