Skip to content

Commit

Permalink
feat!: Remove the django-splash app.
Browse files Browse the repository at this point in the history
DEPR: openedx/public-engineering#224

The django-splash repo was created 11 years ago to let the LMS redirect
users to a splash screen when a user comes to the site for the first
time. It works by looking for a configurable cookie value and
redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults,
and is not compatible with MFEs.

BREAKING CHANGE: The django splash feature will no longer be available.
  • Loading branch information
feanil committed Apr 17, 2024
1 parent 28a105b commit 4f76e35
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions lms/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -2270,8 +2270,6 @@ def _make_locale_paths(settings): # pylint: disable=missing-function-docstring
'openedx.core.djangoapps.cors_csrf.middleware.CorsCSRFMiddleware',
'openedx.core.djangoapps.cors_csrf.middleware.CsrfCrossDomainCookieMiddleware',

'splash.middleware.SplashMiddleware',

'openedx.core.djangoapps.geoinfo.middleware.CountryMiddleware',
'openedx.core.djangoapps.embargo.middleware.EmbargoMiddleware',

Expand Down Expand Up @@ -3146,9 +3144,6 @@ def _make_locale_paths(settings): # pylint: disable=missing-function-docstring
# Notes
'lms.djangoapps.edxnotes',

# Splash screen
'splash',

# User API
'rest_framework',

Expand Down
1 change: 0 additions & 1 deletion requirements/edx/kernel.in
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ django-pipeline
django-ratelimit
django-sekizai
django-simple-history
django-splash
django-statici18n
django-storages
django-user-tasks
Expand Down

0 comments on commit 4f76e35

Please sign in to comment.