Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: django-splash #224

Closed
ormsbee opened this issue Jan 25, 2024 · 2 comments
Closed

[DEPR]: django-splash #224

ormsbee opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@ormsbee
Copy link

ormsbee commented Jan 25, 2024

Proposal Date

2024-01-25

Target Ticket Acceptance Date

2024-02-09

Earliest Open edX Named Release Without This Functionality

Redwood - 2024-04

Rationale

The django-splash repo was created 11 years ago to let the LMS redirect users to a splash screen when a user comes to the site for the first time. It works by looking for a configurable cookie value and redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults, and is not compatible with MFEs.

Removal

Replacement

There is no planned replacement for this.

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

@ormsbee ormsbee self-assigned this Jan 25, 2024
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Jan 25, 2024
@ormsbee ormsbee moved this from Proposed to Communicated in DEPR: Deprecation & Removal Feb 8, 2024
@ormsbee
Copy link
Author

ormsbee commented Feb 9, 2024

@ormsbee ormsbee moved this from Communicated to Accepted in DEPR: Deprecation & Removal Feb 9, 2024
@dianakhuang dianakhuang moved this from Accepted to Deprecated in DEPR: Deprecation & Removal Apr 4, 2024
feanil added a commit to openedx/edx-platform that referenced this issue Apr 17, 2024
DEPR: openedx/public-engineering#224

The django-splash repo was created 11 years ago to let the LMS redirect
users to a splash screen when a user comes to the site for the first
time. It works by looking for a configurable cookie value and
redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults,
and is not compatible with MFEs.

BREAKING CHANGE: The django splash feature will no longer be available.
feanil added a commit to openedx/edx-platform that referenced this issue Apr 18, 2024
DEPR: openedx/public-engineering#224

The django-splash repo was created 11 years ago to let the LMS redirect
users to a splash screen when a user comes to the site for the first
time. It works by looking for a configurable cookie value and
redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults,
and is not compatible with MFEs.

BREAKING CHANGE: The django splash feature will no longer be available.
@feanil
Copy link
Contributor

feanil commented Apr 19, 2024

The code has been removed from edx-platform and the repository has been archived. Waiting a little bit to make sure there are no regressions before closing this.

@feanil feanil closed this as completed Apr 20, 2024
@github-project-automation github-project-automation bot moved this from Deprecated to Removed in DEPR: Deprecation & Removal Apr 20, 2024
KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this issue Apr 24, 2024
DEPR: openedx/public-engineering#224

The django-splash repo was created 11 years ago to let the LMS redirect
users to a splash screen when a user comes to the site for the first
time. It works by looking for a configurable cookie value and
redirecting from the middleware.

This feature was never documented, has some edx.org hardcoded defaults,
and is not compatible with MFEs.

BREAKING CHANGE: The django splash feature will no longer be available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Archived in project
Development

No branches or pull requests

2 participants