Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles issue for the "Upload a CSV file" field #31286

Conversation

bydawen
Copy link
Contributor

@bydawen bydawen commented Nov 14, 2022

Fixed in the Instructor > Certificate page, markup styles for the "Upload a CSV file" field

@bydawen
Copy link
Contributor Author

bydawen commented Nov 14, 2022

Hi! I'm contributing on behalf of Raccoongang

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @bydawen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bydawen bydawen changed the title Fix styles issue for the "Upload a CSV file" field on the Instructor … Fix styles issue for the "Upload a CSV file" field Nov 14, 2022
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 16, 2022
@mphilbrick211
Copy link

Hi @bydawen - I have pinged our internal team to allow tests to run on this.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 27, 2022
@mphilbrick211
Copy link

Hi @arbrandes and @brian-smith-tcril! Could you please review / merge this if it's good-to-go?

@mphilbrick211
Copy link

Hi @arbrandes and @brian-smith-tcril! Just putting this back on the radar.

@arbrandes
Copy link
Contributor

@mphilbrick211, @bydawen: it is good practice to have a fix merged to master first, and then backport that into the release branches, starting with the newest one. I see, however, that the one to master has been closed, as well as Olive, for lack of activity from the author.

Can we get those re-opened and tackled first, before we get back here?

@arbrandes arbrandes removed their request for review May 16, 2023 15:51
@pomegranited
Copy link
Contributor

Addressed by #32330

@openedx-webhooks
Copy link

@bydawen Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants