Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jasmine tests quieter #409

Merged
merged 1 commit into from
Jul 17, 2013
Merged

Conversation

cpennington
Copy link
Contributor

@nedbat @wedaly: Review?

@@ -45,3 +45,4 @@ node_modules
autodeploy.properties
.ws_migrations_complete
.vagrant/
logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already a ../log directory, maybe we don't need this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins doesn't have that directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And ruby doesn't know about the python variables that define the log directory.

@wedaly
Copy link
Contributor

wedaly commented Jul 17, 2013

👍

@nedbat
Copy link
Contributor

nedbat commented Jul 17, 2013

Merge it! 👍

cpennington added a commit that referenced this pull request Jul 17, 2013
@cpennington cpennington merged commit 726a85c into master Jul 17, 2013
@cpennington cpennington deleted the cale/make-jasmine-tests-quieter branch July 17, 2013 17:58
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
started gradebook design; moved a few nav classes
yokose-ks added a commit to nttks/edx-platform that referenced this pull request Oct 15, 2015
…nslation-for-gacco-cypress

Fix translation for enter-course button and help modal (openedx#409)
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
* azimpradhan/update-ftreponse-sha:
  Update to latest SHA for xblock-free-text-response
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Before edx-platform version 19ba691,
only `lms_web_url` was exposed from the course
blocks API. Now that the API also exposes
`legacy_web_url`, we can stop falling back
to `lms_web_url` when `legacy_web_url` is
absent.

TNL-7796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants