feat: Adds additional error reasons to SubsidyAccessPolicy #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
commented
Jul 24, 2023
brobro10000
commented
Jul 24, 2023
Comment on lines
349
to
362
| if not content_metadata: | ||
| return (False, REASON_CONTENT_NOT_IN_CATALOG, existing_transactions) | ||
|
|
||
| if not subsidy_can_redeem_payload.get('can_redeem', False): | ||
| return (False, REASON_NOT_ENOUGH_VALUE_IN_SUBSIDY, existing_transactions) | ||
|
|
There was a problem hiding this comment.
Logic swapped to avoid additional call into the subsidies can_redeem. Check if the content_metadata exist in the catalog before checking on a subsidy level.
4 tasks
brobro10000
force-pushed
the
hu/ent-7223
branch
4 times, most recently
from
578f52c
to
3603243
Compare
macdiesel
reviewed
Jul 24, 2023
| return (False, REASON_SUBSIDY_EXPIRED, []) | ||
|
|
||
| # inactive policy with spend remaining (could have redeemed) | ||
| if not self.active and not self.will_exceed_spend_limit(content_key, content_metadata=content_metadata): |
There was a problem hiding this comment.
This and the changes on like 149 are a little sus i think. I synced with @brobro10000 on slack with some suggestions. He's going to take another look at the logic in here.
There was a problem hiding this comment.
Going to take another look at it after our discussion yesterday 👍🏽
macdiesel
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more reasons and an additional error message for learner credit in the
SubsidyAccessPolicymodel for thecan_redeemendpoint.Additional logic needed within the enterprise-subsidy repository to specify if a subsidy is not active by checking
isActivewithin the subsidycan_redeemendpointPending Tests