feat: add active field to subsidies, can-redeem's CanRedeemResult return
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
changed the title
brobro10000
changed the title
brobro10000
changed the title
active field to subsidies, can-redeem's CanRedeemResult return
brobro10000
force-pushed
the
hu/ent-7223
branch
4 times, most recently
from
d3e7698
to
41c55e2
Compare
macdiesel
reviewed
Jul 24, 2023
| @@ -90,6 +90,7 @@ def can_redeem(subsidy, lms_user_id, content_key): | |||
| ) | |||
| """ | |||
| existing_transaction = subsidy.get_committed_transaction_no_reversal(lms_user_id, content_key) | |||
| is_active = subsidy.is_active | |||
There was a problem hiding this comment.
Since the is_active field is not part of the model I would have expected you to calculate the is_active flag here and not just assign it? I don't think this will work.
There was a problem hiding this comment.
Hamzah set me straight:
Ahh the is_active field is computed against the expiration date. There was no need to recompute it again, just assign a value based on the subsidy. If it’s true or false return that value
macdiesel
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an active response to the 'can-redeem' endpoint.
Its purpose is to allow the policies 'can-redeem' endpoint to be able to determine if the subsidy is active and return the correct messaging to the user in the front end
Related to PR: openedx/enterprise-access#223
Description
Describe in a couple of sentences what this PR adds
Testing instructions
Add some, if applicable
Merge checklist