Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgraded frontend-build version to v12" #624

Closed

Conversation

alangsto
Copy link
Contributor

@alangsto alangsto commented Aug 18, 2022

Reverts #613

The PR being reverted is causing edits to form fields on the account settings page to error:

Screen Shot 2022-08-18 at 4 29 32 PM (1)

Reverting because we would like to release a form for COPPA compliance, but we are blocked from deploying to prod by the errors from this PR.

@alangsto
Copy link
Contributor Author

fyi @BilalQamar95

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #624 (37a43f2) into master (ad6f812) will decrease coverage by 0.14%.
The diff coverage is 53.96%.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   39.24%   39.10%   -0.15%     
==========================================
  Files         109      109              
  Lines        2227     2235       +8     
  Branches      597      598       +1     
==========================================
  Hits          874      874              
- Misses       1268     1276       +8     
  Partials       85       85              
Impacted Files Coverage Δ
src/account-settings/AccountSettingsPage.jsx 0.00% <0.00%> (ø)
src/account-settings/EditableField.jsx 73.91% <ø> (ø)
src/account-settings/coaching/CoachingToggle.jsx 0.00% <0.00%> (ø)
src/account-settings/data/reducers.js 0.00% <0.00%> (ø)
src/account-settings/data/selectors.js 0.00% <ø> (ø)
.../account-settings/delete-account/DeleteAccount.jsx 68.57% <ø> (ø)
...ount-settings/demographics/DemographicsSection.jsx 87.75% <ø> (ø)
...ount-settings/reset-password/ConfirmationAlert.jsx 0.00% <0.00%> (ø)
...settings/reset-password/RequestInProgressAlert.jsx 0.00% <0.00%> (ø)
.../account-settings/reset-password/ResetPassword.jsx 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abdullahwaheed
Copy link
Contributor

abdullahwaheed commented Aug 19, 2022

@alangsto ValidationFormGroup is removed in #612 and i have tested this locally. I think we should merge it and this issue will automatically resolve
image

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR to revert.
I am wondering if we can fix forward.
Do we know the root cause of the bug where the edit name button leads directly to error view?

@alangsto alangsto closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants