Upgraded frontend-build version to v12 #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 39.69% 39.84% +0.14%
==========================================
Files 108 108
Lines 2194 2186 -8
Branches 586 585 -1
==========================================
Hits 871 871
+ Misses 1238 1230 -8
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…alqamar95/frontend-build-upgrade
|
Oof - package-lock.json conflicts. Mind rebasing? |
davidjoy
reviewed
Aug 11, 2022
| return bTimeSinceEpoch - aTimeSinceEpoch; | ||
| } | ||
|
|
||
| sortVerifiedNameRecords = verifiedNameHistory => { |
There was a problem hiding this comment.
Was this function unused?
There was a problem hiding this comment.
Yes, this function was unused & was triggering react/no-unused-class-component-methods rule, therefore I removed it.
davidjoy
approved these changes
Aug 11, 2022
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
42: Upgrade eslint to v8.x
What changed?
frontend-buildto v12 (Eslint was updated infrontend-buildversion resulting in it's version being bumped to v12. This PR updatesfrontend-buildto reciprocate eslint version update)eslintissues