Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Persian language Support #666

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

CodeWithEmad
Copy link
Member

Feature: Persian language Support

Hello everyone
I'm glad to announce that we translated all openedx components in transifex to Persian and fa_IR is 100% translated and 100% reviewed.

in this PR, I've added:
new translations to i18n/messages/fa_IR.json,
fa-ir in messages in src/i18n/index.js,
fa-ir code in constants.js in src/account-settings/site-language,
and fa_IR code in transifex_langs variable in Makefile.

is there anything else I should do?

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 17, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@ishahroz ishahroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Kindly resolve the sync conflicts before we can merge.

@mphilbrick211
Copy link

Hi @CodeWithEmad! Just following-up on this pull request. Looks like changes have been requested and branch conflicts need to be resolved. Please let us know if you plan to pursue this PR. Thanks!

@CodeWithEmad CodeWithEmad force-pushed the feature/persian-language branch from fa6d5bf to 58ceb46 Compare January 12, 2023 12:43
@CodeWithEmad
Copy link
Member Author

Hi @mphilbrick211
all conflicts resolved

Copy link
Contributor

@ishahroz ishahroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

name: 'فارسی',
released: true,
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeWithEmad Linting is failing here because expected indentation is of 2 spaces but found 4. Kindly resolve, so we can merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishahroz if this looks good to you now, can you merge?

@CodeWithEmad CodeWithEmad force-pushed the feature/persian-language branch from 58ceb46 to ce67e6f Compare January 18, 2023 16:11
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 23, 2023
@mphilbrick211
Copy link

Just popping in to say I'm looking into getting these tests authorized!

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 38.63% // Head: 38.63% // No change to project coverage 👍

Coverage data is based on head (ce67e6f) compared to base (4b10316).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   38.63%   38.63%           
=======================================
  Files         110      110           
  Lines        2288     2288           
  Branches      624      624           
=======================================
  Hits          884      884           
  Misses       1319     1319           
  Partials       85       85           
Impacted Files Coverage Δ
src/account-settings/site-language/constants.js 0.00% <ø> (ø)
src/i18n/index.js 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211 mphilbrick211 added changes requested and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Jan 27, 2023
@mphilbrick211
Copy link

Hi @CodeWithEmad! Just flagging for you that tests have run, but changes have been requested.

@CodeWithEmad
Copy link
Member Author

@mphilbrick211 I fixed the linting issue, last week. @ishahroz might forgot to approve the requested changes.

@mphilbrick211
Copy link

Thanks, @CodeWithEmad! @ishahroz would you mind taking a look? Thank you!

@ishahroz ishahroz merged commit 3c5aa05 into openedx:master Feb 1, 2023
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the feature/persian-language branch February 1, 2023 06:51
moonesque pushed a commit to edSPIRIT/frontend-app-account that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants