-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Persian language Support #666
Feature: Persian language Support #666
Conversation
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Kindly resolve the sync conflicts before we can merge.
Hi @CodeWithEmad! Just following-up on this pull request. Looks like changes have been requested and branch conflicts need to be resolved. Please let us know if you plan to pursue this PR. Thanks! |
fa6d5bf
to
58ceb46
Compare
Hi @mphilbrick211 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
name: 'فارسی', | ||
released: true, | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeWithEmad Linting is failing here because expected indentation is of 2 spaces but found 4. Kindly resolve, so we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishahroz if this looks good to you now, can you merge?
58ceb46
to
ce67e6f
Compare
Just popping in to say I'm looking into getting these tests authorized! |
Codecov ReportBase: 38.63% // Head: 38.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 38.63% 38.63%
=======================================
Files 110 110
Lines 2288 2288
Branches 624 624
=======================================
Hits 884 884
Misses 1319 1319
Partials 85 85
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @CodeWithEmad! Just flagging for you that tests have run, but changes have been requested. |
@mphilbrick211 I fixed the linting issue, last week. @ishahroz might forgot to approve the requested changes. |
Thanks, @CodeWithEmad! @ishahroz would you mind taking a look? Thank you! |
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Feature: Persian language Support
Hello everyone
I'm glad to announce that we translated all openedx components in transifex to Persian and fa_IR is 100% translated and 100% reviewed.
in this PR, I've added:
new translations to
i18n/messages/fa_IR.json
,fa-ir
in messages insrc/i18n/index.js
,fa-ir
code in constants.js insrc/account-settings/site-language
,and
fa_IR
code in transifex_langs variable inMakefile
.is there anything else I should do?