-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Persian language support added #385
Conversation
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@BbrSofiane or @arbrandes would either of you be up for reviewing this as Core Contributors on this repo? This one is very tiny, though there are also some related PRs with actual translations like openedx/frontend-app-learning#989 openedx/frontend-app-account#666 which may take more time to review. |
Hi @arbrandes! Just checking to make sure this is still on the radar :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @CodeWithEmad!
@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
this PR will add support for Persain Language (fa_IR) to the project.
as I mentioned here right now we translated all edx-platform's components to Persian but when I wanted to add translations to the Microfronteds, RTL was not supported for fa-ir, so here we are :)
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: