feat: Profile image on user posts #574

vladislavkeblysh · 2023-10-11T16:18:53Z

Description

Added profile image on user avatar posts
Added env variable to toggle image display

openedx-webhooks · 2023-10-11T16:18:59Z

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

itsjeyd · 2023-10-17T14:37:42Z

Hey @vladislavkeblysh, thank you for this contribution!

@jmakowski1123 This seems to be a user-facing change, so we would need a feature ticket for it. Could you please create one?

Palm backport: feat: Profile image on user posts (palm.master) #573
Quince backport: feat: Profile image on user posts (quince.master) #575

CC @mphilbrick211

codecov · 2023-10-17T15:52:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (3ef8515) to head (a5675d7).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   93.17%   93.18%           
=======================================
  Files         161      161           
  Lines        3401     3405    +4     
  Branches      919      923    +4     
=======================================
+ Hits         3169     3173    +4     
  Misses        215      215           
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

itsjeyd · 2023-11-02T10:03:03Z

@jmakowski1123 When you get a minute could you please create a feature ticket for this PR and the backports listed above?

itsjeyd · 2023-11-17T08:24:32Z

@jmakowski1123 @awais-ansari It sounds like product review for this PR has already started (?). If so, could you please point me to where that conversation is happening? It doesn't seem like we have a feature ticket for this PR, so it's hard for me to tell what its current status is.

CC @mphilbrick211

itsjeyd · 2023-11-29T08:16:29Z

@vladislavkeblysh Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#577 and Palm/Quince backports, #582 and Palm/Quince backports).

CC @mphilbrick211

awais-ansari · 2023-12-01T10:59:06Z

@vladislavkeblysh @itsjeyd I started a thread on the openEdx slack to speed up the process.
CC: @mphilbrick211

nedbat · 2023-12-01T11:22:31Z

I can let Product handle the question in more detail, but my understanding is that some sites don't want this due to privacy concerns, so it may need to be the operator's choice whether to enable it.

jmakowski1123 · 2023-12-14T01:01:08Z

Apologies for the delay. Lots of open questions regarding this PR, please see here: openedx/platform-roadmap#314 (comment)

itsjeyd · 2023-12-14T09:17:04Z

Thanks a lot for the update and product feedback @jmakowski1123! 🙂

@vladislavkeblysh Product review will continue via openedx/platform-roadmap#314, the feature ticket for this PR. Please have a look at that ticket when you can and address the questions raised in this comment.

CC @awais-ansari @mphilbrick211

vladislavkeblysh · 2024-12-10T16:43:26Z

Ready to review!

awais-ansari · 2024-12-13T12:57:12Z

.env.development

@@ -23,3 +23,4 @@ USER_INFO_COOKIE_NAME='edx-user-info'
 SUPPORT_URL='https://support.edx.org'
 LEARNER_FEEDBACK_URL=''
 STAFF_FEEDBACK_URL=''
+ENABLE_PROFILE_IMAGE='true'


Disable it by default.

awais-ansari · 2024-12-23T14:04:00Z

.env.development

@@ -23,3 +23,4 @@ USER_INFO_COOKIE_NAME='edx-user-info'
 SUPPORT_URL='https://support.edx.org'
 LEARNER_FEEDBACK_URL=''
 STAFF_FEEDBACK_URL=''
+ENABLE_PROFILE_IMAGE='true'


change it into empty string

awais-ansari · 2024-12-23T14:04:41Z

src/discussions/post-comments/comments/comment/CommentHeader.jsx

@@ -24,6 +27,8 @@ const CommentHeader = ({
    closed,
  });

+  const profileImage = getConfig().ENABLE_PROFILE_IMAGE === 'true' && postUsers && Object.values(postUsers)[0].profile.image;


Can we simplify it?

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023

vladislavkeblysh marked this pull request as draft October 11, 2023 16:49

vladislavkeblysh force-pushed the keblysh/feat/user-avatar-master branch from 3c919ed to 1874a20 Compare October 11, 2023 17:02

vladislavkeblysh changed the title ~~feat: Profile image on user posts (palm.master)~~ feat: Profile image on user posts Oct 11, 2023

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 11, 2023

vladislavkeblysh marked this pull request as ready for review October 12, 2023 08:16

mphilbrick211 added product review PR requires product review before merging and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 17, 2023

awais-ansari assigned ayub02 Oct 24, 2023

vladislavkeblysh force-pushed the keblysh/feat/user-avatar-master branch from c01fe70 to 9367409 Compare November 25, 2023 13:46

cmltaWt0 mentioned this pull request Dec 11, 2023

feat: Profile image on user posts (quince.master) #575

Closed

jmakowski1123 mentioned this pull request Dec 14, 2023

[Product Pull Request] bug: Profile image on user posts openedx/platform-roadmap#314

Open

5 tasks

jmakowski1123 mentioned this pull request Dec 14, 2023

Option to reimplement legacy course breadcrumb navigation openedx/platform-roadmap#315

Closed

2 tasks

itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 14, 2023

awais-ansari removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 11, 2024

awais-ansari unassigned ayub02 Jan 11, 2024

ihor-romaniuk force-pushed the keblysh/feat/user-avatar-master branch from e79030b to f74a297 Compare September 10, 2024 13:32

dyudyunov force-pushed the keblysh/feat/user-avatar-master branch from f74a297 to 2fc5c21 Compare November 8, 2024 08:31

ihor-romaniuk force-pushed the keblysh/feat/user-avatar-master branch from 2fc5c21 to e6e8f0c Compare December 3, 2024 09:17

vladislavkeblysh force-pushed the keblysh/feat/user-avatar-master branch from 3a82ed5 to 07dc9fb Compare December 10, 2024 16:30

feat: add env variable to display image

f192216

vladislavkeblysh force-pushed the keblysh/feat/user-avatar-master branch from 07dc9fb to f192216 Compare December 10, 2024 16:32

feat: add env variable to display image

770cd1f

Merge branch 'master' into keblysh/feat/user-avatar-master

a5675d7

vladislavkeblysh requested review from BilalQamar95, ayesha-waris and awais-ansari and removed request for BilalQamar95 and ayesha-waris December 10, 2024 16:48

awais-ansari requested changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Profile image on user posts #574

feat: Profile image on user posts #574

vladislavkeblysh commented Oct 11, 2023 •

edited

Loading

openedx-webhooks commented Oct 11, 2023 •

edited

Loading

itsjeyd commented Oct 17, 2023

codecov bot commented Oct 17, 2023 •

edited

Loading

itsjeyd commented Nov 2, 2023

itsjeyd commented Nov 17, 2023 •

edited

Loading

itsjeyd commented Nov 29, 2023

awais-ansari commented Dec 1, 2023

nedbat commented Dec 1, 2023

jmakowski1123 commented Dec 14, 2023 •

edited

Loading

itsjeyd commented Dec 14, 2023 •

edited

Loading

vladislavkeblysh commented Dec 10, 2024

awais-ansari Dec 13, 2024

awais-ansari Dec 23, 2024

awais-ansari Dec 23, 2024

feat: Profile image on user posts #574

Are you sure you want to change the base?

feat: Profile image on user posts #574

Conversation

vladislavkeblysh commented Oct 11, 2023 • edited Loading

Description

openedx-webhooks commented Oct 11, 2023 • edited Loading

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

itsjeyd commented Oct 17, 2023

codecov bot commented Oct 17, 2023 • edited Loading

Codecov Report

itsjeyd commented Nov 2, 2023

itsjeyd commented Nov 17, 2023 • edited Loading

itsjeyd commented Nov 29, 2023

awais-ansari commented Dec 1, 2023

nedbat commented Dec 1, 2023

jmakowski1123 commented Dec 14, 2023 • edited Loading

itsjeyd commented Dec 14, 2023 • edited Loading

vladislavkeblysh commented Dec 10, 2024

awais-ansari Dec 13, 2024

Choose a reason for hiding this comment

awais-ansari Dec 23, 2024

Choose a reason for hiding this comment

awais-ansari Dec 23, 2024

Choose a reason for hiding this comment

vladislavkeblysh commented Oct 11, 2023 •

edited

Loading

openedx-webhooks commented Oct 11, 2023 •

edited

Loading

codecov bot commented Oct 17, 2023 •

edited

Loading

itsjeyd commented Nov 17, 2023 •

edited

Loading

jmakowski1123 commented Dec 14, 2023 •

edited

Loading

itsjeyd commented Dec 14, 2023 •

edited

Loading