-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Profile image on user posts (palm.master) #573
feat: Profile image on user posts (palm.master) #573
Conversation
Thanks for the pull request, @vladislavkeblysh! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@vladislavkeblysh Thank you for this contribution! |
Hi @vladislavkeblysh! Just flagging that there is a failing check. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #573 +/- ##
============================================================
+ Coverage 92.38% 92.41% +0.02%
============================================================
Files 163 162 -1
Lines 3297 3282 -15
Branches 890 887 -3
============================================================
- Hits 3046 3033 -13
+ Misses 232 230 -2
Partials 19 19 ☔ View full report in Codecov by Sentry. |
@vladislavkeblysh Looks like there are some coverage issues, can you have a look? |
@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs. |
@vladislavkeblysh I see -- the line that the codecov check is complaining about wasn't changed in this PR. Thanks for checking. That probably means it's OK to merge the changes as is, but it'll be up to engineering reviewers to make the final call on that. |
@vladislavkeblysh This change was intentional. This feature is still in product discussion. |
c83160d
to
25221c9
Compare
Closed as redundant (no new release for this version is planned) |
Description