-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editor bar visibility (quince.master) #583
feat: Editor bar visibility (quince.master) #583
Conversation
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@vladislavkeblysh Thank you for this contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #583 +/- ##
=============================================================
Coverage ? 92.43%
=============================================================
Files ? 169
Lines ? 3451
Branches ? 898
=============================================================
Hits ? 3190
Misses ? 241
Partials ? 20 ☔ View full report in Codecov by Sentry. |
@vladislavkeblysh breaking changes have been mentioned here. |
@awais-ansari I have seen it. I will fix it soon, thank you |
d110e6f
to
446483e
Compare
Do we just need to press the merge button, now? Are all issues fixed? |
Master PR: #582 |
There seem to be some issues left to fix on the master PR, so @vladislavkeblysh might need to update this PR and the Palm backport (#581) with some follow-up changes to get them ready for merge. |
@awais-ansari @mphilbrick211 Fixed comment from master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
2dafb6a
into
openedx:open-release/quince.master
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description