-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Editor bar visibility (palm.master) #581
feat: Editor bar visibility (palm.master) #581
Conversation
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
05caa8c
to
5e6324b
Compare
@vladislavkeblysh Thank you for this contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #581 +/- ##
============================================================
+ Coverage 92.38% 92.40% +0.01%
============================================================
Files 163 162 -1
Lines 3297 3278 -19
Branches 890 883 -7
============================================================
- Hits 3046 3029 -17
+ Misses 232 230 -2
Partials 19 19 ☔ View full report in Codecov by Sentry. |
@vladislavkeblysh Looks like there are some coverage issues, can you have a look? |
@e0d The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs. |
@vladislavkeblysh Noted, thanks. As I mentioned here, your reviewers will need to decide if that means the changes are good to merge as is. |
@vladislavkeblysh breaking changes have been mentioned here. |
@awais-ansari I have seen it. I will fix it soon, thank you |
5e6324b
to
abfe59d
Compare
This should be ready to merge after the master is all set, @awais-ansari. @vladislavkeblysh - there's a failing check here, would you mind rebasing to see if it fixes itself? |
@awais-ansari @mphilbrick211 Fixed comment from master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM
af2d5b1
into
openedx:open-release/palm.master
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description