Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editor bar visibility (palm.master) #581

Conversation

vladislavkeblysh
Copy link
Contributor

Description

  • Fixed editor bar visibility when scrolling up

Screenshot 2023-10-16 at 12 09 51
Screenshot 2023-10-16 at 12 10 13

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 16, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/editor-bar-palm.master branch from 05caa8c to 5e6324b Compare October 16, 2023 09:11
@vladislavkeblysh vladislavkeblysh changed the title feat: Editor bar visibility feat: Editor bar visibility (palm.master) Oct 16, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (5a10d7e) 92.40%.
Report is 5 commits behind head on open-release/palm.master.

Files Patch % Lines
...c/discussions/discussions-home/FeedbackWrapper.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #581      +/-   ##
============================================================
+ Coverage                     92.38%   92.40%   +0.01%     
============================================================
  Files                           163      162       -1     
  Lines                          3297     3278      -19     
  Branches                        890      883       -7     
============================================================
- Hits                           3046     3029      -17     
+ Misses                          232      230       -2     
  Partials                         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d
Copy link

e0d commented Oct 17, 2023

@vladislavkeblysh Looks like there are some coverage issues, can you have a look?

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. product review PR requires product review before merging labels Oct 24, 2023
@vladislavkeblysh
Copy link
Contributor Author

@e0d The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

@itsjeyd
Copy link

itsjeyd commented Nov 8, 2023

@vladislavkeblysh Noted, thanks.

As I mentioned here, your reviewers will need to decide if that means the changes are good to merge as is.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 8, 2023
@awais-ansari awais-ansari added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 8, 2023
@awais-ansari
Copy link
Contributor

@vladislavkeblysh breaking changes have been mentioned here.

@awais-ansari awais-ansari removed the product review PR requires product review before merging label Nov 8, 2023
@vladislavkeblysh
Copy link
Contributor Author

@awais-ansari I have seen it. I will fix it soon, thank you

@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Nov 15, 2023
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/editor-bar-palm.master branch from 5e6324b to abfe59d Compare November 25, 2023 13:31
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 29, 2023
@mphilbrick211
Copy link

mphilbrick211 commented Dec 15, 2023

This should be ready to merge after the master is all set, @awais-ansari.

@vladislavkeblysh - there's a failing check here, would you mind rebasing to see if it fixes itself?

@awais-ansari awais-ansari added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed product review PR requires product review before merging labels Dec 18, 2023
@vladislavkeblysh
Copy link
Contributor Author

@awais-ansari @mphilbrick211 Fixed comment from master

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@awais-ansari awais-ansari merged commit af2d5b1 into openedx:open-release/palm.master Jan 3, 2024
5 of 6 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari awais-ansari added merged and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants