Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container indents and style imports #599

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Nov 6, 2023

Description

This pull request contains:

  • a small fix for navigation container side indents and make them the same
  • fix paragon and brand style imports (prepending module paths with a ~ tells webpack to search through node_modules)

Related Pull Requests

PR to the open-release/quince.master branch: #601
PR to the master branch: #600

Screenshots/sandbox (optional):

Before After
image image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (dc05734) 92.40%.
Report is 2 commits behind head on open-release/palm.master.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #599      +/-   ##
============================================================
+ Coverage                     92.38%   92.40%   +0.01%     
============================================================
  Files                           163      162       -1     
  Lines                          3297     3278      -19     
  Branches                        890      883       -7     
============================================================
- Hits                           3046     3029      -17     
+ Misses                          232      230       -2     
  Partials                         19       19              
Files Coverage Δ
...c/discussions/discussions-home/DiscussionsHome.jsx 94.73% <ø> (-0.27%) ⬇️
src/discussions/messages.js 100.00% <ø> (ø)
src/index.jsx 0.00% <ø> (ø)
...c/discussions/discussions-home/FeedbackWrapper.jsx 92.85% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 6, 2023
@sarina
Copy link
Contributor

sarina commented Nov 6, 2023

Codecov is failing because it says the non-modified file discussions/discussions-home/FeedbackWrapper.jsx was modified and is not covered. I believe this PR can be merged

@awais-ansari awais-ansari merged commit cb28557 into openedx:open-release/palm.master Nov 7, 2023
4 of 5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the merged label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants