Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container indents and style imports #600

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Nov 6, 2023

Description

This pull request contains:

  • a small fix for navigation container side indents and make them the same
  • fix paragon and brand style imports (prepending module paths with a ~ tells webpack to search through node_modules)

Related Pull Requests

PR to the open-release/palm.master branch: #599
PR to the open-release/quince.master branch: #601

Screenshots/sandbox (optional):

Before After
image image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4994de9) 92.37% compared to head (8078f6f) 92.37%.
Report is 2 commits behind head on master.

❗ Current head 8078f6f differs from pull request most recent head 4b9b149. Consider uploading reports for the commit 4b9b149 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         169      169           
  Lines        3450     3450           
  Branches      898      898           
=======================================
  Hits         3187     3187           
  Misses        243      243           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @openedx/edx-infinity! This is ready for review / merge. Thanks!

@awais-ansari
Copy link
Contributor

@ihor-romaniuk Please update this PR.

@ihor-romaniuk
Copy link
Contributor Author

@awais-ansari PR was updated

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 8, 2023
@sundasnoreen12
Copy link
Contributor

@ihor-romaniuk please rebase with master again

@awais-ansari awais-ansari removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 8, 2023
Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase with the master.

@ihor-romaniuk
Copy link
Contributor Author

@awais-ansari @sundasnoreen12 rebased

@awais-ansari awais-ansari merged commit 48b2b9d into openedx:master Nov 14, 2023
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/fix-container-indent-and-style-imports-master branch November 14, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants