Updated frontend-build to v12

[BilalQamar95]

Ticket:
42: Upgrade eslint to v8.x

What changed?

• Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)
• Resolved eslint issues post update

[codecov]

Codecov Report

Base: 86.68% // Head: 86.83% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (612906a) compared to base (b500546).
Patch coverage: 97.77% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
+ Coverage   86.68%   86.83%   +0.15%     
==========================================
  Files         252      252              
  Lines        4295     4329      +34     
  Branches     1097     1096       -1     
==========================================
+ Hits         3723     3759      +36     
+ Misses        553      551       -2     
  Partials       19       19              

Impacted Files	Coverage Δ
.../access-expiration-alert/AccessExpirationAlert.jsx	0.00% <0.00%> (ø)
src/alerts/enrollment-alert/EnrollmentAlert.jsx	0.00% <0.00%> (ø)
src/alerts/enrollment-alert/clickHook.js	100.00% <ø> (ø)
...rc/alerts/logistration-alert/LogistrationAlert.jsx	0.00% <0.00%> (ø)
src/course-home/live-tab/LiveTab.jsx	0.00% <0.00%> (ø)
src/generic/notices/NoticesProvider.jsx	100.00% <ø> (ø)
src/generic/tabs/useIndexOfLastVisibleChild.js	95.65% <ø> (ø)
src/generic/user-messages/hooks.js	100.00% <ø> (ø)
src/alerts/access-expiration-alert/hooks.js	66.66% <50.00%> (+1.96%)	⬆️
src/product-tours/ProductTours.jsx	59.01% <75.00%> (+0.68%)	⬆️
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[arbrandes]

@BilalQamar95, do you mind resolving conflicts? Thanks!

[leangseu-edx]

Do we need to check this? I think it is probably more reasonable to check just 8. Not all of node@16 correspond to npm@8.5.

[BilalQamar95]

This check was added to resolve ci dependency issues

[leangseu-edx]

There seems to be some issue with your package-lock.json if the ci fail. For example, this pr no longer have package.json change and yet package-lock.json persist. I would suggest remove this and package-lock.json.

[leangseu-edx]

There is recent change to upgrade frontend-build@12. https://github.com/openedx/frontend-app-learning/pull/1017/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 I appreciate you taking your time to fix the linting. If you rebase this pr to master, I definitely can help getting this merge.

[leangseu-edx]

I made a couple change by rebasing the change then remove package-lock.json and .github/workflows/validate.yml. I tested with everything working.