Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded frontend-build version to v12 #589

Merged
merged 8 commits into from
Sep 20, 2022

Conversation

BilalQamar95
Copy link
Contributor

GIT Ticket: 42: Upgrade eslint to v8.x

What changed?

  • Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)

@BilalQamar95 BilalQamar95 requested a review from a team July 19, 2022 06:42
@BilalQamar95 BilalQamar95 self-assigned this Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Base: 64.96% // Head: 64.96% // No change to project coverage 👍

Coverage data is based on head (bd48d48) compared to base (011c4ef).
Patch coverage: 44.00% of modified lines in pull request are covered.

❗ Current head bd48d48 differs from pull request most recent head 4a40868. Consider uploading reports for the commit 4a40868 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files          45       45           
  Lines         805      805           
  Branches      156      156           
=======================================
  Hits          523      523           
  Misses        272      272           
  Partials       10       10           
Impacted Files Coverage Δ
src/profile/data/reducers.js 0.00% <0.00%> (ø)
src/profile/ProfilePage.jsx 82.19% <7.69%> (ø)
src/profile/forms/SocialLinks.jsx 98.43% <88.88%> (ø)
src/profile/forms/elements/EditableItemHeader.jsx 85.71% <100.00%> (ø)
src/i18n/index.jsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tj-Tracy Tj-Tracy force-pushed the bilalqamar95/frontend-build-upgrade branch from bd48d48 to 4a40868 Compare September 20, 2022 20:10
@Tj-Tracy Tj-Tracy merged commit d7d6cd8 into master Sep 20, 2022
@Tj-Tracy Tj-Tracy deleted the bilalqamar95/frontend-build-upgrade branch September 20, 2022 20:13
snglth pushed a commit to Abstract-Tech/community-theme-profile that referenced this pull request Jul 12, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants