Upgrade eslint to v8.x #252
Conversation
|
So one thing we're probably going to want to do is to understand what, if any, rules we're about to break in the applications and packages that depend on frontend-build when we merge this. i.e., we've upgraded eslint through multiple major version upgrades, what changed? Will all our apps suddenly start having a bunch of linting errors? If rules have changed, I think we need to make this a major version bump of frontend-build. @adamstankiewicz and @arbrandes, what do you think? |
|
It's a bit nebulous with a package like frontend-build, but I think I might consider this a |
|
So I do see some of our apps, depending on frontend-build, to have linting issues with this update. Details regarding breaking changes |
There was a problem hiding this comment.
I say we consider this a breaking change in frontend-build if it'll result in linting issues. That way folks can be intentional about upgrading to it, rather than having it blow up their build.
So FYI, to do that with semantic-release, the commit message needs to include BREAKING CHANGE: and we should describe the breaking changes in as much detail as we can. That'll cause semantic-release to bump frontend-build's version number by a major increment.
If we squash commits and specify a new commit message with feat: in the subject and BREAKING CHANGE: in the body, that'll be sufficient. I'm going to approve with the expectation that we'll just do that.
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ticket
42: Upgrade eslint to v8.x
Description:
eslintto v8.18 along with@edx/eslint-config