Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update make upgrade command #104

Merged
merged 1 commit into from
Sep 7, 2022
Merged

build: update make upgrade command #104

merged 1 commit into from
Sep 7, 2022

Conversation

UsamaSadiq
Copy link
Member

Description

  • Updated the make upgrade target to test installing the pip.txt and pip-tools.txt to verify if the updated pip && pip-tools versions are compatible with each other.
  • Added common_constraints.txt in the requirements folder to follow global edX constraints.

TODO

  • Removing django<3 constraint will update the Django to next major version which would be breaking/major change so that'll be done in a separate PR.

@UsamaSadiq UsamaSadiq mentioned this pull request Sep 7, 2022
Closed
mariajgrimaldi
mariajgrimaldi approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks again. And good call updating Django in another PR! Let me know if I can help you with it.

@mariajgrimaldi mariajgrimaldi merged commit 5a0dfa2 into openedx:main Sep 7, 2022
@UsamaSadiq UsamaSadiq mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UsamaSadiq @mariajgrimaldi