fix: Install pip and pip-tools in upgrade script

[Jawayria]

Updated the upgrade target script to check the compatibility of upgraded pip and pip-tools versions. For reference, look at this openedx/edx-repo-health#271 for new check added in edx-repo-health.

[mariajgrimaldi]

Hello! Can you check the failing tests? they might be related to the libraries update for docs.in

[mariajgrimaldi]

why don't you add these constraints into the constraints.txt? & justify them please

[mariajgrimaldi]

This worked for me in the constraints.txt, then I just get some doc errors but it doesn't crash

doc8==0.10.1
edx_sphinx_theme==3.0.0
Sphinx==4.5.0

This is how I tested after installing tox:
TOXENV=docs tox
But remember to justify the pinning. Do we need it?

[Jawayria]

I did it to test if new package versions were a problem

[mariajgrimaldi]

Try with readme-renderer

[Jawayria]

Usama Sadiq will carry this forward

[mariajgrimaldi]

You should remove this constraint since it's a bit old

[mariajgrimaldi]

I think I made this work by:

[testenv:docs]
setenv =
    PYTHONPATH = {toxinidir}
    SPHINXOPTS = -W
whitelist_externals =
    make
    rm
    twine
deps =
    -r{toxinidir}/requirements/doc.txt
commands =
    doc8 --ignore-path docs/_build README.rst docs
    rm -f docs/openedx_events.rst
    rm -f docs/modules.rst
    # -e allows for overriding setting from the environment so that SPHINXOPTS gets picked up.
    make -e -C docs clean
    make -e -C docs html
    python setup.py sdist bdist_wheel
    twine check --strict dist/*

Also adding twine to requirements/docs.in
I used this repo as reference

[mariajgrimaldi]

Hello there @UsamaSadiq! We're eager to push this PR forward with the changes suggested. Is there something we can do? Let me know!

[UsamaSadiq]

Sure @mariajgrimaldi , I'll finalise the PR with suggested changes within next week and will let you know.

[mariajgrimaldi]

Hello there! I merged some changes that may fix your CI issue, so you might not need more changes.

[UsamaSadiq]

@mariajgrimaldi I don't have access to update this PR and Jawayria has changed her team so I've created a new PR with all the suggested changes.
Please close this PR and review the above mentioned PR.

[mariajgrimaldi]

Got it! @UsamaSadiq, thanks for continuing this!