Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to v8.x #1421

Merged
merged 18 commits into from
Sep 27, 2022
Merged

Conversation

BilalQamar95
Copy link
Contributor

Description

Ticket
42: Upgrade eslint to v8.x

Description:

  • Upgraded eslint to v8.18 along with @edx/eslint-config
  • Resolved linting issues post upgrade.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@BilalQamar95 BilalQamar95 requested a review from a team June 24, 2022 13:52
@BilalQamar95 BilalQamar95 self-assigned this Jun 24, 2022
@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit 7e93f18
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6332bc01b333170008d90381
😎 Deploy Preview https://deploy-preview-1421--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Base: 91.62% // Head: 90.40% // Decreases project coverage by -1.21% ⚠️

Coverage data is based on head (c223aa7) compared to base (adf708d).
Patch coverage: 72.01% of modified lines in pull request are covered.

❗ Current head c223aa7 differs from pull request most recent head 7e93f18. Consider uploading reports for the commit 7e93f18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   91.62%   90.40%   -1.22%     
==========================================
  Files         208      208              
  Lines        3547     3534      -13     
  Branches      824      824              
==========================================
- Hits         3250     3195      -55     
- Misses        282      324      +42     
  Partials       15       15              
Impacted Files Coverage Δ
src/Alert/index.jsx 87.50% <0.00%> (-9.87%) ⬇️
src/Button/index.jsx 73.33% <0.00%> (-26.67%) ⬇️
src/Card/CardStatus.jsx 100.00% <ø> (ø)
src/Collapsible/CollapsibleAdvanced.jsx 88.57% <ø> (ø)
src/Collapsible/CollapsibleVisible.jsx 100.00% <ø> (ø)
src/Collapsible/index.jsx 69.23% <ø> (ø)
src/DataTable/CardView.jsx 20.00% <0.00%> (-7.28%) ⬇️
src/DataTable/SidebarFilters.jsx 16.66% <0.00%> (-8.34%) ⬇️
src/DataTable/TableFilters.jsx 30.00% <0.00%> (-10.00%) ⬇️
src/Dropdown/deprecated/index.jsx 94.84% <ø> (ø)
... and 105 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@adamstankiewicz
Copy link
Member

@BilalQamar95 When you merge this, let's use a chore commit as I don't think it'll be necessary to trigger a new release for these eslint fixes?

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/fed-bom-eslint-upgrade branch from 84424f9 to 8aa2724 Compare June 28, 2022 12:00
@jmbowman jmbowman added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 25, 2022
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/fed-bom-eslint-upgrade branch from e22cf3f to 3abdeda Compare August 17, 2022 11:13
@abdullahwaheed abdullahwaheed added engineering review and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 25, 2022
@BilalQamar95 BilalQamar95 merged commit 2e7847f into master Sep 27, 2022
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/fed-bom-eslint-upgrade branch September 27, 2022 09:14
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants