-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: add ability to use unlabeled Radio and Checkbox components in respective Form sets #1988
[BD-46] feat: add ability to use unlabeled Radio and Checkbox components in respective Form sets #1988
Conversation
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
+ Coverage 91.38% 91.39% +0.01%
==========================================
Files 234 234
Lines 4120 4126 +6
Branches 982 984 +2
==========================================
+ Hits 3765 3771 +6
Misses 348 348
Partials 7 7
☔ View full report in Codecov by Sentry. |
35d39ed
to
364e35c
Compare
@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixes
SelectableBox
props warning by using unlabeled variants ofForm.Checkbox
andForm.Radio
components.Deploy Preview
https://deploy-preview-1988--paragon-openedx.netlify.app/components/form/form-radio/#unlabeled-control
https://deploy-preview-1988--paragon-openedx.netlify.app/components/selectablebox/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist