Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: add ability to use unlabeled Radio and Checkbox components in respective Form sets #1988

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Jan 31, 2023

Description

Fixes SelectableBox props warning by using unlabeled variants of Form.Checkbox and Form.Radio components.

Deploy Preview

https://deploy-preview-1988--paragon-openedx.netlify.app/components/form/form-radio/#unlabeled-control
https://deploy-preview-1988--paragon-openedx.netlify.app/components/selectablebox/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jan 31, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 31, 2023

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 364e35c
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64784fed1e4c6d00086dd506
😎 Deploy Preview https://deploy-preview-1988--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (0a2fbb3) 91.38% compared to head (364e35c) 91.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
+ Coverage   91.38%   91.39%   +0.01%     
==========================================
  Files         234      234              
  Lines        4120     4126       +6     
  Branches      982      984       +2     
==========================================
+ Hits         3765     3771       +6     
  Misses        348      348              
  Partials        7        7              
Impacted Files Coverage Δ
src/Form/FormRadioSetContext.jsx 100.00% <ø> (ø)
src/Form/index.jsx 100.00% <ø> (ø)
src/Form/FormCheckbox.jsx 100.00% <100.00%> (ø)
src/Form/FormRadio.jsx 100.00% <100.00%> (ø)
src/SelectableBox/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov marked this pull request as draft January 31, 2023 15:10
@viktorrusakov viktorrusakov marked this pull request as ready for review February 3, 2023 08:22
@viktorrusakov viktorrusakov linked an issue Apr 21, 2023 that may be closed by this pull request
3 tasks
@viktorrusakov viktorrusakov force-pushed the vrusakov/fix-selectabel-box-warning branch from 35d39ed to 364e35c Compare June 1, 2023 07:59
@adamstankiewicz adamstankiewicz merged commit 309189d into openedx:master Jun 2, 2023
@openedx-webhooks
Copy link

@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unavoidable warning with SelectableBox
4 participants