Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] fix: clean up errors in tests #2226

Merged
merged 4 commits into from
Apr 27, 2023
Merged

[BD-46] fix: clean up errors in tests #2226

merged 4 commits into from
Apr 27, 2023

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Apr 25, 2023 •
edited
Loading

Description

Issue: #2225

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Apr 25, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Apr 25, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 79924ec
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/644a70327a19580008507f1b
😎 Deploy Preview https://deploy-preview-2226--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this pull request Apr 25, 2023
Closed
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (4939562) 91.07% compared to head (79924ec) 90.97%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2226      +/-   ##
==========================================
- Coverage   91.07%   90.97%   -0.10%     
==========================================
  Files         234      234              
  Lines        4122     4123       +1     
  Branches      981      982       +1     
==========================================
- Hits         3754     3751       -3     
- Misses        361      365       +4     
  Partials        7        7
Impacted Files Coverage Δ
src/Dropdown/deprecated/index.jsx 94.84% <ø> (ø)
src/Modal/PopperElement.jsx 100.00% <100.00%> (ø)
src/ProductTour/CheckpointBreadcrumbs.jsx 100.00% <100.00%> (ø)
src/ProductTour/index.jsx 92.06% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-errors-in-tests branch from e25456a to d3d54d4 Compare April 25, 2023 20:04
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-errors-in-tests branch from ad1cdd5 to f24c2e0 Compare April 26, 2023 07:30
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: clean up errors in tests [BD-46] fix: clean up errors in tests Apr 26, 2023
viktorrusakov
viktorrusakov reviewed Apr 27, 2023
View reviewed changes
src/IconButtonToggle/IconButtonToggle.test.jsx Outdated Show resolved Hide resolved
src/Menu/select-menu.md
</SelectMenu>
```

#### Linked variant

```jsx live
<SelectMenu isLink={true} defaultMessage="Choose Your New Best Friend">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this? isLink is a valid prop I think (you can probably remove ={true} part to improve code-style, but not the whole prop)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks

src/Menu/SelectMenu.test.jsx Outdated Show resolved Hide resolved
src/Modal/PopperElement.jsx Outdated
@@ -30,7 +30,8 @@ PopperElement.defaultProps = {
PopperElement.propTypes = {
children: PropTypes.node,
target: PropTypes.shape({
current: PropTypes.node,
// eslint-disable-next-line react/forbid-prop-types
current: PropTypes.object,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common issue with eslint 😄, you should use PropTypes.shape({}) instead to indicate that you expect an object. (and eslint won't complain then)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

src/SelectableBox/index.jsx Outdated Show resolved Hide resolved
src/Modal/PopperElement.test.jsx Outdated Show resolved Hide resolved
@viktorrusakov viktorrusakov linked an issue Apr 27, 2023 that may be closed by this pull request
Clean up errors in tests #2225
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-errors-in-tests branch 2 times, most recently from 34f1ba8 to 2ff674d Compare April 27, 2023 09:56
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fixed-errors-in-tests branch from 2ff674d to 79924ec Compare April 27, 2023 12:53
@viktorrusakov viktorrusakov merged commit 3b2eead into openedx:master Apr 27, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viktorrusakov viktorrusakov mentioned this pull request Apr 27, 2023
Merged
10 tasks
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorrusakov viktorrusakov viktorrusakov approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up errors in tests
4 participants
@PKulkoRaccoonGang @openedx-webhooks @edx-semantic-release @viktorrusakov