Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: revert PopperElement changes #2234

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Apr 27, 2023

Description

Changes in #2226 broke ModalPopup positioning.
image

Reverting them to fix it.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Apr 27, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit a9a3393
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/644ab3718796d900070ed2d2
😎 Deploy Preview https://deploy-preview-2234--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b81cf4) 90.97% compared to head (a9a3393) 90.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2234   +/-   ##
=======================================
  Coverage   90.97%   90.97%           
=======================================
  Files         234      234           
  Lines        4123     4123           
  Branches      982      982           
=======================================
  Hits         3751     3751           
  Misses        365      365           
  Partials        7        7           
Impacted Files Coverage Δ
src/Modal/PopperElement.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viktorrusakov viktorrusakov merged commit 9017b69 into master Apr 27, 2023
@viktorrusakov viktorrusakov deleted the rusakov/fix-popper branch April 27, 2023 18:19
@openedx-webhooks
Copy link

@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.32.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants