-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: revert PopperElement changes #2234
Conversation
Thanks for the pull request, @viktorrusakov! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2234 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 234 234
Lines 4123 4123
Branches 982 982
=======================================
Hits 3751 3751
Misses 365 365
Partials 7 7
☔ View full report in Codecov by Sentry. |
@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.32.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.0.0-alpha.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes in #2226 broke
ModalPopup
positioning.Reverting them to fix it.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist