Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Cannot run Rust tests on Parity Gitlab in the specific scenario #6507

Closed
grbIzl opened this issue Sep 12, 2017 · 1 comment
Closed

Cannot run Rust tests on Parity Gitlab in the specific scenario #6507

grbIzl opened this issue Sep 12, 2017 · 1 comment
Labels
F2-bug 🐞 The client fails to follow expected behavior. M1-ci 🙉 Continuous integration. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Milestone
1.9 Velocity

Comments

@grbIzl
Copy link
Collaborator

grbIzl commented Sep 12, 2017

Please look through #6312

  1. I've made a commit with Rust and Js code b316852. The checks failed because of syntax error in Js code
  2. I've fixed syntax error in js and made new commit b18d555. This time it contained only Js code.
  3. I see in logs of Gitlab jobs for the last commit "Skipping Rust tests since no Rust files modified." message. And all checks are green now.

Actual results:
Rust tests were not run after the first commit and they were not run after the second one. All checks are green.

Expected results:
I need to run Rust tests for the first commit (of for changes made in terms of the first commit) somehow.
@grbIzl grbIzl added the M1-ci 🙉 Continuous integration. label Sep 12, 2017
@rphmeier
Copy link
Contributor

cc @paritytech/ci

@5chdn 5chdn added F2-bug 🐞 The client fails to follow expected behavior. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Sep 12, 2017
@5chdn 5chdn added this to the 1.8 milestone Oct 5, 2017
@5chdn 5chdn modified the milestones: 1.8, 1.9 Oct 12, 2017
@5chdn 5chdn mentioned this issue Nov 16, 2017
Closed
64 tasks
@debris debris mentioned this issue Dec 29, 2017
Closed
kirushik pushed a commit that referenced this issue Jan 5, 2018
More thorough changes detection
d3bc47f 
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.

Closes #6507
@kirushik kirushik mentioned this issue Jan 5, 2018
Merged
kirushik pushed a commit that referenced this issue Jan 5, 2018
More thorough changes detection
d2ea190 
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.

Closes #6507
kirushik pushed a commit that referenced this issue Jan 5, 2018
More thorough changes detection
bceb25b 
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.

Closes #6507
kirushik pushed a commit that referenced this issue Jan 5, 2018
More thorough changes detection
30e6e99 
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.

Closes #6507
General-Beck pushed a commit that referenced this issue Jan 8, 2018
@kirushik @General-Beck
More thorough changes detection (#7472)
bdc3d6f 
* More thorough changes detection

This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.

Closes #6507

* We don't have Appveyor anymore

* before_script sections are not merged

* Limiting commit depth breaks branching detection
This was referenced Mar 22, 2018
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F2-bug 🐞 The client fails to follow expected behavior. M1-ci 🙉 Continuous integration. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
1.9 Velocity
Development

No branches or pull requests
3 participants
@grbIzl @rphmeier @5chdn