Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Updated jsonrpc to point to the 1.11 branch #8180

Merged
merged 4 commits into from
Mar 24, 2018

Conversation

kirushik
Copy link
Collaborator

No description provided.

@kirushik kirushik added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Mar 21, 2018
@kirushik kirushik requested review from tomusdrw and debris and removed request for debris March 21, 2018 17:45
@debris
Copy link
Collaborator

debris commented Mar 22, 2018

@paritytech/ci it looks like we have a problem with #6507 again

@debris debris added A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 22, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 22, 2018
@kirushik kirushik assigned kirushik and twittner and unassigned kirushik Mar 22, 2018
- `jsonrpc` PR #244 required `hyper >= 0.11.20` which in turn required
updating `tokio-core`, `mio` and `iovec`.

- `jsonrpc` PR #246 required updating `https://github.com/tomusdrw/ws-rs`.
@twittner twittner added A0-pleasereview 🤓 Pull request needs code review. and removed A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. labels Mar 23, 2018
@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Mar 23, 2018
@debris debris merged commit 8c02211 into master Mar 24, 2018
@debris debris deleted the kirushik/update_jsonrpc_to_1_11 branch March 24, 2018 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants