Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Badges do not survive browser refresh #6534

Closed
chevdor opened this issue Sep 17, 2017 · 14 comments · Fixed by #6725
Closed

Badges do not survive browser refresh #6534

chevdor opened this issue Sep 17, 2017 · 14 comments · Fixed by #6725
Assignees
Labels
F2-bug 🐞 The client fails to follow expected behavior. P0-dropeverything 🌋 Everyone should address the issue now.
Milestone

Comments

@chevdor
Copy link

chevdor commented Sep 17, 2017

I'm running:

  • Parity version: master
  • Operating system: MacOS
  • And installed: from source
  • And Browser: Chrome

See also #6518.

I am using a badge known as working (Oprah2).
After certification (calling the certify() function of the badge contract), I wait for the event to fire.
At that point, the badge appears in Parity without any user action.

If the user refreshes the page, the badges are no longer displayed... ever. No refresh, parity restart, etc... make the badge appear again.

The only workaround I found is to revoke() and certify() again. Then the badge shows up again until the next refresh.

@chevdor
Copy link
Author

chevdor commented Sep 17, 2017

This applies to stopping parity, closing the web page and restarting parity.
So the TTL of badges is currently rather short 😢
I just testing that as well on Fundation.

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M7-ui labels Sep 18, 2017
@5chdn
Copy link
Contributor

5chdn commented Sep 18, 2017

Thanks for your report, added this to the long list of annoyances which are not going to be fixed until the new wallet is released. :)

@5chdn 5chdn closed this as completed Sep 18, 2017
@chevdor
Copy link
Author

chevdor commented Sep 18, 2017

Looking forward to the new wallet then :)

@5chdn 5chdn added P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. F2-bug 🐞 The client fails to follow expected behavior. and removed F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. labels Oct 5, 2017
@5chdn 5chdn reopened this Oct 5, 2017
@5chdn 5chdn added this to the 1.8 milestone Oct 5, 2017
@5chdn 5chdn added P0-dropeverything 🌋 Everyone should address the issue now. and removed P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Oct 5, 2017
@5chdn 5chdn modified the milestones: 1.8, Patch Oct 5, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 5, 2017

The following issues are probably related:

In addition, tokens like GavCoin are totally malformed in the wallet, missing TLA and icon, and decimal places are ignored.

I marked these issues with highest priority as this needs to be fixed before the DOTs allocation and to distribute PICOPS badges.

If possible, this should go into 1.7.3 to enable beta users with proper badges and token balances again.

@chevdor
Copy link
Author

chevdor commented Oct 5, 2017

The current workaround for anyone having the issue is to keep your parity open and running, do no refresh, revoke your badge, grant the badge again.
Your badge will show up until you close parity. This is of course a poor workaround but allows you validating your Badge until this issue is fixed.

@5chdn
Copy link
Contributor

5chdn commented Oct 5, 2017

This is not an acceptable workaround :D

@chevdor
Copy link
Author

chevdor commented Oct 12, 2017

I see improvements 👏 but there is still an issue.
Open an account, you will see the badges, now refresh the page => they are gone.

@5chdn
Copy link
Contributor

5chdn commented Oct 12, 2017

are you saying you just pulled latest master and it does not work?

@chevdor
Copy link
Author

chevdor commented Oct 12, 2017 via email

@5chdn
Copy link
Contributor

5chdn commented Oct 12, 2017

Did you rebuild the UI too?

@jacogr
Copy link
Contributor

jacogr commented Oct 12, 2017

It does disappear when on account and then refreshing. Not a P0 issue atm, but an annoyance indeed.

@jacogr jacogr reopened this Oct 12, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 12, 2017

@chevdor adding you to the list of heros for this night.

@5chdn
Copy link
Contributor

5chdn commented Oct 12, 2017

#6730

@5chdn 5chdn closed this as completed Oct 12, 2017
@chevdor
Copy link
Author

chevdor commented Oct 13, 2017

Thank you @jacogr and @5chdn. I am not judging on Prio, just reporting what I see not working as I think it is easier to fix things when they are fresh. I will test again :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F2-bug 🐞 The client fails to follow expected behavior. P0-dropeverything 🌋 Everyone should address the issue now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants