Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix tokens and badges #6725

Merged
merged 5 commits into from
Oct 12, 2017
Merged

Fix tokens and badges #6725

merged 5 commits into from
Oct 12, 2017

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Oct 12, 2017 •
edited
Loading

Closes #6534
This was caused simply because the initial fetching of data (are the accounts certified?) was inexistant. This was introduced when we stopped fetching all previous logs for certifications (which is not something to be done).
Still need to fix badges that might not show up when registering a new badge.

Closes #6658
This was caused because GavCoin has an index of 0, and it f***ed up the displays (thanks Javascript).

Closes #6549
A very dumb mistake of wrong indexes...

Perhaps will fix : #6669
Those requests are now just not displayed. I think it's an issue with RPC per-dapp permissions, because the issue only arise when sending transactions from dapps @tomusdrw

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Oct 12, 2017
@5chdn 5chdn added the A9-FUCKYEAH!1 💯 Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;) label Oct 12, 2017
@5chdn 5chdn added this to the Patch milestone Oct 12, 2017
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 12, 2017
jacogr
jacogr reviewed Oct 12, 2017
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did a bit more than anticipated in places. Would prefer PRs per fix going forward. But really unbelievable effort.

@5chdn 5chdn mentioned this pull request Oct 12, 2017
Closed
67 tasks
@jacogr jacogr merged commit 3e7b775 into master Oct 12, 2017
@jacogr jacogr deleted the fix-tokens branch October 12, 2017 18:09
jacogr pushed a commit that referenced this pull request Oct 12, 2017
@ngotchac @jacogr
Merge #6725
7e8baf7
@jacogr jacogr mentioned this pull request Oct 12, 2017
Merged
arkpar pushed a commit that referenced this pull request Oct 12, 2017
@jacogr @arkpar
Backport #6719 & #6725 (#6726)
8157a83 
* Check vouch status on appId in addition to contentHash (#6719)

* Check vouch status on appId in addition to contentHash

* Simplify var expansion

* Merge #6725

* Add updated MethodDecoding from master
arkpar pushed a commit that referenced this pull request Oct 12, 2017
@jacogr @arkpar
Backport #6719 & #6725 (#6726)
69f53ff 
* Check vouch status on appId in addition to contentHash (#6719)

* Check vouch status on appId in addition to contentHash

* Simplify var expansion

* Merge #6725

* Add updated MethodDecoding from master
@5chdn 5chdn mentioned this pull request Oct 18, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr left review comments

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. A9-buythatmanabeer 🍻 Pull request is reviewed well and worth buying the author a beer. A9-FUCKYEAH!1 💯 Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;)
Projects
None yet
Milestone
Patch
3 participants
@ngotchac @jacogr @5chdn