Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

add tests for ethstore-cli #8027

Closed
debris opened this issue Mar 1, 2018 · 4 comments
Closed

add tests for ethstore-cli #8027

debris opened this issue Mar 1, 2018 · 4 comments
Labels
P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone
1.11 Prosperity

Comments

@debris
Copy link
Collaborator

debris commented Mar 1, 2018

to avoid issues like #8026
@debris debris added P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. labels Mar 1, 2018
@izgzhen
Copy link

izgzhen commented Mar 6, 2018

I'd like to help on this issue :)

@debris
Copy link
Collaborator Author

debris commented Mar 6, 2018

great! :)

@izgzhen
Copy link

izgzhen commented Mar 7, 2018

I wonder if we should move execute in main.rs to library, which can be pulled in conveniently to test code, or should I invoke the built binary directly and test it as a process?

@debris
Copy link
Collaborator Author

debris commented Mar 7, 2018

I would prefer tests invoking built binary

debris pushed a commit that referenced this issue Mar 19, 2018
@debris
Add test for ethstore-cli, fixes #8027
49a0e3c
debris pushed a commit that referenced this issue Mar 22, 2018
@debris
Add test for ethstore-cli, fixes #8027
4a16e4d 
remove println
@5chdn 5chdn added this to the 1.11 milestone Mar 29, 2018
@5chdn 5chdn mentioned this issue Apr 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P5-sometimesoon 🌲 Issue is worth doing soon. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Milestone
1.11 Prosperity
Development

No branches or pull requests
3 participants
@debris @izgzhen @5chdn