This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add test for ethstore-cli #8107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A8-looksgood 🦄
|
the CI failed again ... I don't know why it might happen, but maybe you can try rebase it again. |
debris
force-pushed
the
ethstore-cli-test
branch
from
4ff864d
to
49a0e3c
Compare
|
@paritytech/ci can you help here? I restarted the build / added more commits / rebased pr and it still fails with the same unrelated error... |
rphmeier
reviewed
Mar 20, 2018
ethstore/cli/tests/cli.rs
Outdated
| .unwrap(); | ||
|
|
||
| let dir = TempDir::new("test-vault").unwrap(); | ||
| println!("tempdir: {}", dir.path().to_str().unwrap()); |
There was a problem hiding this comment.
@debris looks like I can't push to this branch, can you help rework the patch here?
There was a problem hiding this comment.
sure! fixed, rebased and put in a new branch again!
5chdn
added
A5-grumble 🔥
|
This was merged in #8027 right? |
5chdn
added
the
Z7-duplicate 🖨
|
@5chdn no, it wasn't :/ |
|
we should reopen it once pr is fixed an CI issues no longer exist |
5chdn
removed
the
Z7-duplicate 🖨
|
this commit? 6e49ff1 |
5chdn
added
A1-onice 🌨
First ``cargo check``
niklasad1
reviewed
Apr 10, 2018
test.sh
Outdated
|
|
||
| # Validate --no-default-features build | ||
| cargo check --no-default-features | ||
| cargo test -j 8 $OPTIONS --features "$FEATURES" --all --exclude evmjit $1 |
There was a problem hiding this comment.
You can remove evmjit here it is removed
5chdn
added
A0-pleasereview 🤓
|
already merged |
5chdn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #8081, where the CI cache is broken