Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

parity-cli: fix docs to properly reflect snapshot period of 5000 #10422

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

jam10o-new
Copy link
Contributor

@jam10o-new jam10o-new commented Feb 26, 2019

closes #10418

@jam10o-new jam10o-new added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B1-patch-beta 🕷🕷 B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 26, 2019
@parity-cla-bot
Copy link

It looks like @joshua-mir signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jam10o-new jam10o-new added this to the 2.5 milestone Feb 26, 2019
Copy link
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to use the constant but probably overkill if rarely changed

@ordian ordian merged commit afc1b72 into master Feb 26, 2019
@ordian ordian deleted the update-snapshot-doc branch February 26, 2019 12:35
@soc1c soc1c added the M3-docs 📑 Documentation. label Feb 27, 2019
@soc1c
Copy link
Contributor

soc1c commented Feb 27, 2019

Title! 😡

@soc1c soc1c changed the title 10000 > 5000 parity-cli: fix docs to properly reflect snapshot period of 5000 Feb 27, 2019
HCastano pushed a commit to HCastano/parity-ethereum that referenced this pull request Feb 27, 2019
HCastano pushed a commit to HCastano/parity-ethereum that referenced this pull request Feb 27, 2019
HCastano added a commit that referenced this pull request Feb 27, 2019
* revert some changes, could be buggy (#10399)

* ci: clean up gitlab-ci.yml leftovers from previous merge (#10429)

* 10000 > 5000 (#10422)

addresses #10418

* fix underflow in pip, closes #10419 (#10423)

* fix panic when logging directory does not exist, closes #10420 (#10424)

* Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417)

* update foundation to #7262209

* update kovan to #10434561

* update ropsten to #5027841

* update classic to #7555073

* Update Ropsten headers to #5101569
HCastano added a commit that referenced this pull request Feb 27, 2019
* revert some changes, could be buggy (#10399)

* 10000 > 5000 (#10422)

addresses #10418

* fix panic when logging directory does not exist, closes #10420 (#10424)

* fix underflow in pip, closes #10419 (#10423)

* ci: clean up gitlab-ci.yml leftovers from previous merge (#10429)

* Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417)

* update foundation to #7262209

* update kovan to #10434561

* update ropsten to #5027841

* update classic to #7555073

* Update Ropsten headers to #5101569
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. M3-docs 📑 Documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot period is 5000 blocks - not 10000 as --help suggests
5 participants