This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
parity-cli: fix docs to properly reflect snapshot period of 5000 #10422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses #10418
jam10o-new
added
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
B1-patch-beta 🕷🕷
B0-patch-stable 🕷
Pull request should also be back-ported to the stable branch.
labels
Feb 26, 2019
It looks like @joshua-mir signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ascjones
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to use the constant but probably overkill if rarely changed
ordian
approved these changes
Feb 26, 2019
Title! 😡 |
soc1c
changed the title
10000 > 5000
parity-cli: fix docs to properly reflect snapshot period of 5000
Feb 27, 2019
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 27, 2019
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 27, 2019
HCastano
added a commit
that referenced
this pull request
Feb 27, 2019
* revert some changes, could be buggy (#10399) * ci: clean up gitlab-ci.yml leftovers from previous merge (#10429) * 10000 > 5000 (#10422) addresses #10418 * fix underflow in pip, closes #10419 (#10423) * fix panic when logging directory does not exist, closes #10420 (#10424) * Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417) * update foundation to #7262209 * update kovan to #10434561 * update ropsten to #5027841 * update classic to #7555073 * Update Ropsten headers to #5101569
HCastano
added a commit
that referenced
this pull request
Feb 27, 2019
* revert some changes, could be buggy (#10399) * 10000 > 5000 (#10422) addresses #10418 * fix panic when logging directory does not exist, closes #10420 (#10424) * fix underflow in pip, closes #10419 (#10423) * ci: clean up gitlab-ci.yml leftovers from previous merge (#10429) * Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417) * update foundation to #7262209 * update kovan to #10434561 * update ropsten to #5027841 * update classic to #7555073 * Update Ropsten headers to #5101569
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A2-insubstantial 👶
Pull request requires no code review (e.g., a sub-repository hash update).
B0-patch-stable 🕷
Pull request should also be back-ported to the stable branch.
M3-docs 📑
Documentation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10418