This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix panic when logging directory does not exist #10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debris
added
A0-pleasereview 🤓
ordian
approved these changes
Feb 26, 2019
ordian
added
A8-looksgood 🦄
jam10o-new
approved these changes
Feb 26, 2019
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 27, 2019
HCastano
pushed a commit
to HCastano/parity-ethereum
that referenced
this pull request
Feb 27, 2019
HCastano
added a commit
that referenced
this pull request
Feb 27, 2019
* revert some changes, could be buggy (#10399) * ci: clean up gitlab-ci.yml leftovers from previous merge (#10429) * 10000 > 5000 (#10422) addresses #10418 * fix underflow in pip, closes #10419 (#10423) * fix panic when logging directory does not exist, closes #10420 (#10424) * Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417) * update foundation to #7262209 * update kovan to #10434561 * update ropsten to #5027841 * update classic to #7555073 * Update Ropsten headers to #5101569
HCastano
added a commit
that referenced
this pull request
Feb 27, 2019
* revert some changes, could be buggy (#10399) * 10000 > 5000 (#10422) addresses #10418 * fix panic when logging directory does not exist, closes #10420 (#10424) * fix underflow in pip, closes #10419 (#10423) * ci: clean up gitlab-ci.yml leftovers from previous merge (#10429) * Update hardcoded headers for Foundation, Ropsten, Kovan and Classic (#10417) * update foundation to #7262209 * update kovan to #10434561 * update ropsten to #5027841 * update classic to #7555073 * Update Ropsten headers to #5101569
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10420