This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Make sure to not mark block header hash as invalid if only the body is wrong. #11356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
reviewed
Dec 30, 2019
sorpaas
approved these changes
Dec 30, 2019
tomusdrw
added
A8-looksgood 🦄
sorpaas
reviewed
Dec 30, 2019
| Error(ErrorKind::Block(BlockError::InvalidTransactionsRoot(_)), _) | | ||
| Error(ErrorKind::Block(BlockError::InvalidUnclesHash(_)), _) => { | ||
| self.verification.bad.lock().insert(raw_hash); | ||
| }, | ||
| _ => { | ||
| self.verification.bad.lock().insert(hash); |
There was a problem hiding this comment.
@tomusdrw I'm thinking maybe it's better to always track bad blocks by raw_hash?
There was a problem hiding this comment.
I think it may require either putting both hashes in or changing some sync code as we expose status(H256) -> Status method, so that other components can check by-hash if particular header was already marked as bad.
I didn't want to change too much in that PR, but I think it may indeed make sense long term.
dvdplm
approved these changes
Dec 30, 2019
sorpaas
approved these changes
Dec 30, 2019
s3krit
pushed a commit
that referenced
this pull request
Dec 30, 2019
…s wrong. (#11356) * Patch invalid transaction root. * Add raw hash to bad and include fix for uncles too. * Fix submodules.
s3krit
pushed a commit
that referenced
this pull request
Dec 30, 2019
ordian
pushed a commit
that referenced
this pull request
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.