Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

.gitlab-ci clean-up #4226 #6600

Closed
wants to merge 7 commits into from
Closed

.gitlab-ci clean-up #4226 #6600

wants to merge 7 commits into from

Conversation

AyushyaChitransh
Copy link

This pull request refers to Issue of .gitlab-ci clean-up #4226

@AyushyaChitransh
Merge pull request #1 from paritytech/master
db56e77 
Update forked repo | Fetch latest changes from master
@AyushyaChitransh
Consolidated scripts of gitlab-ci
0fb31fa 
This commit r
efers to issue #4226 .gitlab-ci clean-up
@AyushyaChitransh
All parameters passed will be executed
2040d0f 
Parameters are the name of gitlab service, which are used as function names in the script. Running this script with service name as parameters will trigger the scripts stored for that service
@AyushyaChitransh
Cleaned .gitlab-ci.yml | Scripts to run from a file
a7c8cbf 
Every job has its function in ./scripts/gitlab-ci.sh.

The file is used to run scripts defined in the job. The scripts corresponding to a job can be run by passing the job-name as argument to the script
@parity-cla-bot
Copy link

It looks like @AyushyaChitransh hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@AyushyaChitransh
Copy link
Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @AyushyaChitransh signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M1-ci 🙉 Continuous integration. labels Sep 27, 2017
@5chdn
Copy link
Contributor

5chdn commented Sep 27, 2017 •
edited
Loading

Both tests failing.

$ chmod +x ./scripts/gitlab-ci.sh
$ ./scripts/gitlab-ci.sh js-test
./scripts/gitlab-ci.sh: line 335: syntax error near unexpected token `('
./scripts/gitlab-ci.sh: line 335: `   set INCLUDE=C:\Program Files (x86)\Microsoft SDKs\Windows\v7.1A\Include;C:\vs2015\VC\include;C:\Program Files (x86)\Windows Kits\10\Include\10.0.10240.0\ucrt'
ERROR: Job failed: exit code 1

@AyushyaChitransh
Copy link
Author

There are some problems with the script for windows. I will try to get this done by tomorrow.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Sep 28, 2017
@5chdn
Copy link
Contributor

5chdn commented Sep 28, 2017

@paritytech/ci ^

@5chdn 5chdn mentioned this pull request Oct 2, 2017
Closed
@arkpar arkpar added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 5, 2017
@arkpar
Copy link
Collaborator

arkpar commented Oct 5, 2017

Will get merged after 1.8 release. Still needs a review from @General-Beck or someone from @paritytech/ci

@5chdn 5chdn added this to the 1.9 milestone Oct 5, 2017
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 6, 2017
@5chdn 5chdn requested review from General-Beck and a team October 6, 2017 19:10
@General-Beck
Copy link
Contributor

after 1.8

@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Oct 12, 2017
@5chdn
Copy link
Contributor

5chdn commented Oct 17, 2017

hey @General-Beck if you have time, could you have a look? thanks.

@5chdn
Copy link
Contributor

5chdn commented Oct 19, 2017

Two tests fail. Windows:

$ chmod +x ./scripts/gitlab-ci.sh
'chmod' is not recognized as an internal or external command,
operable program or batch file.
ERROR: Job failed: exit status 9009

And Push-Release:

Running with gitlab-ci-multi-runner 9.5.1 (96b34cc)
  on cepheus-docker (8df025c2)
Using Docker executor with image parity/rust:gitlab-ci ...
ERROR: Preparation failed: Error: No such image: gitlab/gitlab-runner-helper:x86_64-96b34cc
Will be retried in 3s ...
Using Docker executor with image parity/rust:gitlab-ci ...
ERROR: Preparation failed: Error: No such image: gitlab/gitlab-runner-helper:x86_64-96b34cc
Will be retried in 3s ...
Using Docker executor with image parity/rust:gitlab-ci ...
ERROR: Preparation failed: Error: No such image: gitlab/gitlab-runner-helper:x86_64-96b34cc
Will be retried in 3s ...
ERROR: Job failed (system failure): Error: No such image: gitlab/gitlab-runner-helper:x86_64-96b34cc

@General-Beck
Copy link
Contributor

I'm working on it. several errors.

@debris
Copy link
Collaborator

debris commented Nov 10, 2017

any update on it?

@debris
Copy link
Collaborator

debris commented Nov 16, 2017

I like the pr a lot, but due to inactivity I'm closing it. Feel free to reopen when it's ready.
cc @AyushyaChitransh @paritytech/ci

@debris debris closed this Nov 16, 2017
@AyushyaChitransh
Copy link
Author

There shall be a new PR at about the end of this weekend! The scripts in this PR were outdated, and some builds were also failing. Hope that new PR would be better than this one! 😄

@5chdn
Copy link
Contributor

5chdn commented Nov 17, 2017

maybe @paritytech/ci can comment what's required to get this merged. no need to waste the time of our contributors.

@5chdn 5chdn added A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@General-Beck General-Beck Awaiting requested review from General-Beck

Assignees
No one assigned
Labels
A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. M1-ci 🙉 Continuous integration.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
6 participants
@AyushyaChitransh @parity-cla-bot @5chdn @arkpar @General-Beck @debris