Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

.gitlab-ci clean-up #4226

Closed
jesuscript opened this issue Jan 19, 2017 · 5 comments
Closed

.gitlab-ci clean-up #4226

jesuscript opened this issue Jan 19, 2017 · 5 comments
Labels
F6-refactor 📚 Code needs refactoring. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually. Q0-trivial 🎠 Can be fixed by anyone with access to a computer.
Milestone

Comments

@jesuscript
Copy link
Contributor

jesuscript commented Jan 19, 2017

we can move the code from the scripts blocks into scripts, e.g.

  script:
    - cargo build -j $(nproc) --release --features final $CARGOFLAGS
    - strip target/release/parity
    - export SHA3=$(target/release/parity tools hash target/release/parity)
    - md5sum target/release/parity > parity.md5
    - sh scripts/deb-build.sh amd64
    - cp target/release/parity deb/usr/bin/parity
    ...

can become

  script:
    - ./scripts/run-build.sh

with run-build.sh containing

#!/bin/bash
cargo build -j $(nproc) --release --features final $CARGOFLAGS
strip target/release/parity
export SHA3=$(target/release/parity tools hash target/release/parity)
md5sum target/release/parity > parity.md5
sh scripts/deb-build.sh amd64
cp target/release/parity deb/usr/bin/parity
...

If nothing else, it will make the CI file much cleaner, as it's become a bit of a monster

@jesuscript jesuscript added F6-refactor 📚 Code needs refactoring. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually. labels Jan 19, 2017
@5chdn
Copy link
Contributor

5chdn commented Aug 30, 2017

@paritytech/ci anyone willing to do this?

@5chdn 5chdn added the Q0-trivial 🎠 Can be fixed by anyone with access to a computer. label Aug 30, 2017
@eagleusb
Copy link

eagleusb commented Oct 2, 2017

I can give it a hand, it seriously needs to be refactored/outsourced with scripts.
Also, we can rationalize the .gitlab-ci.yml file with YAML anchors to not repeat the same blocks.

@5chdn
Copy link
Contributor

5chdn commented Oct 2, 2017

@gooodmorningopenstack see #6600 before you start working on this :)

@eagleusb
Copy link

eagleusb commented Oct 3, 2017

Thanks, I see that it's almost done 👍

@5chdn 5chdn added this to the 1.10 & ... milestone Oct 5, 2017
General-Beck added a commit that referenced this issue Jan 10, 2018
Resolves issue #4226 #7086 ci #63 close PR #7506
@5chdn
Copy link
Contributor

5chdn commented Jan 10, 2018

f400a7e

@5chdn 5chdn closed this as completed Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F6-refactor 📚 Code needs refactoring. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually. Q0-trivial 🎠 Can be fixed by anyone with access to a computer.
Projects
None yet
Development

No branches or pull requests

3 participants