Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

.gitlab-ci cleanup | Resolves issue #4226 #7086

Closed
wants to merge 6 commits into from
Closed

.gitlab-ci cleanup | Resolves issue #4226 #7086

wants to merge 6 commits into from

Conversation

AyushyaChitransh
Copy link

This pull request refers to Issue of .gitlab-ci clean-up #4226

@parity-cla-bot
Copy link

It looks like @AyushyaChitransh signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@AyushyaChitransh
Copy link
Author

The PR needs a review from @General-Beck or someone from @paritytech/ci

@debris
Copy link
Collaborator

debris commented Nov 18, 2017

lgtm, @jesuscript can you also review this pr?

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. M1-ci 🙉 Continuous integration. labels Nov 18, 2017
@General-Beck
Copy link
Contributor

I think here I will make more optimizations. and this script does not work in windows. tomorrow I will change the part and check

jacogr
jacogr reviewed Nov 21, 2017
View reviewed changes
.gitlab-ci.yml Outdated
- aws s3api put-object --bucket %S3_BUCKET% --key %CI_BUILD_REF_NAME%/x86_64-pc-windows-msvc/win-installer.zip.md5 --body nsis\win-installer.zip.md5
- curl --data "commit=%CI_BUILD_REF%&sha3=%SHA3%&filename=parity.exe&secret=%RELEASES_SECRET%" http://update.parity.io:1337/push-build/%CI_BUILD_REF_NAME%/%PLATFORM%
- curl --data "commit=%CI_BUILD_REF%&sha3=%SHA3%&filename=parity.exe&secret=%RELEASES_SECRET%" http://update.parity.io:1338/push-build/%CI_BUILD_REF_NAME%/%PLATFORM%
- ./scripts/gitlab-ci.sh windows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this part will run on Windows, it doesn't support bash by default.

jacogr
jacogr reviewed Nov 21, 2017
View reviewed changes
scripts/gitlab-ci.sh Outdated
@@ -0,0 +1,451 @@
linux-stable(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need a #!/bin/sh in here? (Additionally, just make sure the script in +x - not sure how to check for review)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, but its good to have #!/bin/sh

jacogr
jacogr reviewed Nov 21, 2017
View reviewed changes
scripts/gitlab-ci.sh
curl --data "commit=$CI_BUILD_REF&sha3=$SHA3&filename=parity&secret=$RELEASES_SECRET" http://update.parity.io:1338/push-build/$CI_BUILD_REF_NAME/$PLATFORM
}

windows(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather move to gitlab-ci.bat and be certain it is for Windows. (See previous comment)

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 21, 2017
@AyushyaChitransh
Copy link
Author

There have been some updates to fix previously mentioned problems. And the script works on windows platform also now.

@5chdn 5chdn added this to the 1.9 milestone Nov 23, 2017
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 23, 2017
@debris
Copy link
Collaborator

debris commented Nov 27, 2017

@General-Beck @paritytech/ci please review again

@tomusdrw
Copy link
Collaborator

@paritytech/ci please review

@5chdn 5chdn added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Dec 30, 2017
@5chdn 5chdn modified the milestones: 1.9, 1.10 Dec 30, 2017
@5chdn 5chdn removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jan 5, 2018
@5chdn 5chdn modified the milestones: 1.10, 1.9 Jan 5, 2018
@5chdn 5chdn added the P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. label Jan 5, 2018
@debris debris mentioned this pull request Jan 8, 2018
Merged
General-Beck added a commit that referenced this pull request Jan 10, 2018
@General-Beck
.gitlab-ci cleanup
f400a7e 
Resolves issue #4226 #7086 ci #63 close PR #7506
@5chdn
Copy link
Contributor

5chdn commented Jan 10, 2018

It's in f400a7e now - thanks :)

@5chdn 5chdn closed this Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr left review comments

@barrymac barrymac Awaiting requested review from barrymac

@General-Beck General-Beck Awaiting requested review from General-Beck

@jesuscript jesuscript Awaiting requested review from jesuscript

@ddorgan ddorgan Awaiting requested review from ddorgan

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
1.9 Velocity
Development

Successfully merging this pull request may close these issues.
7 participants
@AyushyaChitransh @parity-cla-bot @debris @General-Beck @tomusdrw @5chdn @jacogr