Cap PyTest version to avoid failures #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
approved these changes
Nov 16, 2018
fpagnoux
reviewed
Nov 16, 2018
| ## 24.8.0 [#765](https://github.com/openfisca/openfisca-core/pull/765) | ||
|
|
||
| - Add called parameters to Web API `/trace` endpoint | ||
| - Adds called parameters to Web API `/trace` endpoint |
There was a problem hiding this comment.
Why this change?
Like for commit messages, I think using the imperative mood is preferable for changelog messages. Looking down at the previous versions, there seems to be a trend to use the indicative, but that's pretty recent, and I don't think we should go that way.
There was a problem hiding this comment.
Consistency with nearby parts of the Changelog, which used the indicative (24.7.0, 24.6.6, I overlooked 24.6.8). You're right, it's been inconsistent lately (even in some cases inconsistent in the same version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTest 4 is currently breaking CI builds, this PR limits the range of PyTest versions to < 4.0 to avoid that.